2026-06-17 17:06:30 -06:00
|
|
|
import { beforeEach, describe, expect, it, vi } from 'vitest';
|
|
|
|
|
import { createApiFetch } from './client';
|
|
|
|
|
|
|
|
|
|
const ORIGIN = 'https://cloud.example';
|
|
|
|
|
|
|
|
|
|
function jsonResponse(status: number, body: unknown = {}): Response {
|
|
|
|
|
return new Response(JSON.stringify(body), { status });
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
describe('createApiFetch — 401 refresh/retry parity', () => {
|
2026-06-21 19:03:07 +02:00
|
|
|
let onSessionExpired: ReturnType<typeof vi.fn<() => void>>;
|
2026-06-17 17:06:30 -06:00
|
|
|
|
|
|
|
|
beforeEach(() => {
|
2026-06-21 19:03:07 +02:00
|
|
|
onSessionExpired = vi.fn<() => void>();
|
2026-06-17 17:06:30 -06:00
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it('passes through a non-401 response untouched (no refresh)', async () => {
|
|
|
|
|
const rawFetch = vi.fn().mockResolvedValue(jsonResponse(200, { ok: true }));
|
|
|
|
|
const apiFetch = createApiFetch({ rawFetch, onSessionExpired, origin: ORIGIN });
|
|
|
|
|
|
|
|
|
|
const res = await apiFetch(`${ORIGIN}/api/files`);
|
|
|
|
|
|
|
|
|
|
expect(res.status).toBe(200);
|
|
|
|
|
expect(rawFetch).toHaveBeenCalledTimes(1);
|
|
|
|
|
expect(onSessionExpired).not.toHaveBeenCalled();
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it('on 401 refreshes once then retries the original request', async () => {
|
|
|
|
|
const rawFetch = vi
|
|
|
|
|
.fn()
|
|
|
|
|
.mockResolvedValueOnce(jsonResponse(401)) // original
|
|
|
|
|
.mockResolvedValueOnce(jsonResponse(200)) // refresh ok
|
|
|
|
|
.mockResolvedValueOnce(jsonResponse(200, { retried: true })); // retry
|
|
|
|
|
const apiFetch = createApiFetch({ rawFetch, onSessionExpired, origin: ORIGIN });
|
|
|
|
|
|
|
|
|
|
const res = await apiFetch(`${ORIGIN}/api/files`);
|
|
|
|
|
|
|
|
|
|
expect(res.status).toBe(200);
|
|
|
|
|
expect(await res.json()).toEqual({ retried: true });
|
|
|
|
|
expect(rawFetch).toHaveBeenNthCalledWith(
|
|
|
|
|
2,
|
|
|
|
|
'/api/auth/refresh',
|
|
|
|
|
expect.objectContaining({ method: 'POST' })
|
|
|
|
|
);
|
|
|
|
|
expect(rawFetch).toHaveBeenCalledTimes(3);
|
|
|
|
|
expect(onSessionExpired).not.toHaveBeenCalled();
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it('fires session-expired and throws when refresh fails', async () => {
|
|
|
|
|
const rawFetch = vi
|
|
|
|
|
.fn()
|
|
|
|
|
.mockResolvedValueOnce(jsonResponse(401)) // original
|
|
|
|
|
.mockResolvedValueOnce(jsonResponse(401)); // refresh fails
|
|
|
|
|
const apiFetch = createApiFetch({ rawFetch, onSessionExpired, origin: ORIGIN });
|
|
|
|
|
|
|
|
|
|
await expect(apiFetch(`${ORIGIN}/api/files`)).rejects.toThrow('Session expired');
|
|
|
|
|
expect(onSessionExpired).toHaveBeenCalledTimes(1);
|
|
|
|
|
expect(rawFetch).toHaveBeenCalledTimes(2); // original + refresh, NO retry
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it('deduplicates concurrent 401s into a single refresh', async () => {
|
|
|
|
|
let refreshCalls = 0;
|
|
|
|
|
const rawFetch = vi.fn(async (input: RequestInfo | URL) => {
|
|
|
|
|
const url = typeof input === 'string' ? input : (input as Request).url;
|
|
|
|
|
if (url.includes('/api/auth/refresh')) {
|
|
|
|
|
refreshCalls++;
|
|
|
|
|
await new Promise((r) => setTimeout(r, 10));
|
|
|
|
|
return jsonResponse(200);
|
|
|
|
|
}
|
|
|
|
|
// First hit per resource is a 401; retries (after refresh) succeed.
|
|
|
|
|
return jsonResponse(refreshCalls > 0 ? 200 : 401);
|
|
|
|
|
});
|
|
|
|
|
const apiFetch = createApiFetch({ rawFetch, onSessionExpired, origin: ORIGIN });
|
|
|
|
|
|
|
|
|
|
const [a, b] = await Promise.all([
|
|
|
|
|
apiFetch(`${ORIGIN}/api/files`),
|
|
|
|
|
apiFetch(`${ORIGIN}/api/folders`)
|
|
|
|
|
]);
|
|
|
|
|
|
|
|
|
|
expect(a.status).toBe(200);
|
|
|
|
|
expect(b.status).toBe(200);
|
|
|
|
|
expect(refreshCalls).toBe(1); // single shared refresh
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it('passes cross-origin 401s through without refreshing', async () => {
|
|
|
|
|
const rawFetch = vi.fn().mockResolvedValue(jsonResponse(401));
|
|
|
|
|
const apiFetch = createApiFetch({ rawFetch, onSessionExpired, origin: ORIGIN });
|
|
|
|
|
|
|
|
|
|
const res = await apiFetch('https://third-party.example/api/thing');
|
|
|
|
|
|
|
|
|
|
expect(res.status).toBe(401);
|
|
|
|
|
expect(rawFetch).toHaveBeenCalledTimes(1); // no refresh attempt
|
|
|
|
|
expect(onSessionExpired).not.toHaveBeenCalled();
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it.each([
|
|
|
|
|
'/api/auth/login',
|
|
|
|
|
'/api/auth/logout',
|
|
|
|
|
'/api/auth/refresh',
|
|
|
|
|
'/api/auth/register',
|
|
|
|
|
'/api/auth/setup',
|
|
|
|
|
'/api/auth/oidc/start',
|
|
|
|
|
'/api/auth/device/code',
|
|
|
|
|
'/api/s/sometoken'
|
|
|
|
|
])('bypasses refresh for auth primitive / public share: %s', async (path) => {
|
|
|
|
|
const rawFetch = vi.fn().mockResolvedValue(jsonResponse(401));
|
|
|
|
|
const apiFetch = createApiFetch({ rawFetch, onSessionExpired, origin: ORIGIN });
|
|
|
|
|
|
|
|
|
|
const res = await apiFetch(`${ORIGIN}${path}`);
|
|
|
|
|
|
|
|
|
|
expect(res.status).toBe(401);
|
|
|
|
|
expect(rawFetch).toHaveBeenCalledTimes(1);
|
|
|
|
|
expect(onSessionExpired).not.toHaveBeenCalled();
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it('retries user-data endpoints under /api/auth/ (e.g. me)', async () => {
|
|
|
|
|
const rawFetch = vi
|
|
|
|
|
.fn()
|
|
|
|
|
.mockResolvedValueOnce(jsonResponse(401)) // original /api/auth/me
|
|
|
|
|
.mockResolvedValueOnce(jsonResponse(200)) // refresh ok
|
|
|
|
|
.mockResolvedValueOnce(jsonResponse(200, { id: 'u1' })); // retry
|
|
|
|
|
const apiFetch = createApiFetch({ rawFetch, onSessionExpired, origin: ORIGIN });
|
|
|
|
|
|
|
|
|
|
const res = await apiFetch(`${ORIGIN}/api/auth/me`);
|
|
|
|
|
|
|
|
|
|
expect(res.status).toBe(200);
|
|
|
|
|
expect(await res.json()).toEqual({ id: 'u1' });
|
|
|
|
|
expect(rawFetch).toHaveBeenCalledTimes(3);
|
|
|
|
|
});
|
|
|
|
|
});
|