cjw/Oxicloud
1
0
Fork 0
Code Issues Pull Requests Actions 4 Packages Projects Releases Wiki Activity

Merge pull request #327 from EdouardVanbelle/style/claude-please-please-please-no-more-duplicate

Browse Source 
style(claude): minimize code duplicate...
This commit is contained in:
Dionisio Pozo
2026-04-27 22:02:02 +02:00
committed by GitHub
parent 84b5f1da4e 444d242e63
commit 05d3b2abaa
1 changed files with 14 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
CLAUDE.md
+14
View File
@@ -112,6 +112,13 @@ The server exposes multiple protocol interfaces simultaneously:
Tests are primarily `#[cfg(test)]` modules within source files (~36 files have inline tests). Dedicated test files exist at `*_test.rs` alongside their source. The `test_utils` feature flag enables `mockall` mock generation for trait-heavy testing. No separate `tests/` directory. Tests are primarily `#[cfg(test)]` modules within source files (~36 files have inline tests). Dedicated test files exist at `*_test.rs` alongside their source. The `test_utils` feature flag enables `mockall` mock generation for trait-heavy testing. No separate `tests/` directory.
### Code duplication
Never duplicate logic across handlers or services. If the same behaviour is needed in more than one place, extract it into a shared function, method, or service before writing the second callsite. Preferred homes by layer:
- Cross-handler request logic → method on `CoreServices` or `AppState` (`common/di.rs`)
- Reusable infrastructure behaviour → method on the relevant service struct
- Shared port behaviour → default method on the trait
# Frontend part # Frontend part
## Code conventions ## Code conventions
@@ -140,6 +147,13 @@ Tests are primarily `#[cfg(test)]` modules within source files (~36 files have i
async function updateUser(user, role = 'viewer') { … } async function updateUser(user, role = 'viewer') { … }
``` ```
### Code duplication
Never duplicate logic across JS modules. If the same behaviour is needed in more than one place, extract it into a shared utility function and import it. Preferred homes:
- DOM/UI helpers → `static/js/utils/` or an existing utility module
- API call wrappers → the relevant API module (e.g. `api/files.js`)
- Event or state patterns shared across components → a dedicated shared module
### CSS ### CSS
- BEM methodology for class names (`.block__element--modifier`) - BEM methodology for class names (`.block__element--modifier`)
- CSS custom properties in `:root` for colors and spacing - CSS custom properties in `:root` for colors and spacing