perf: round 11 — StoragePath joined-only, classifier fusion, memoized bodies, query-shape pack, SPA fine-grained stars

Backend (each change benchmark-gated with BEFORE replicas + equivalence
gates; see examples/bench_round11_micro.rs, bench_round11_queries.rs,
bench_log_writer.rs and benches/ROUND11.md — final numbers land in the
follow-up doc commit):

- StoragePath re-representation: single canonical joined String, segments
  derived on demand; File/Folder drop the duplicated path_string field
  (4000→1000 allocs per 500-row listing page)
- Display classifier fusion: classify_display shares one stack-lowered
  extension across the three decision trees; call sites in FileDto,
  folder/favorites/recent handlers, trash, path-resolver (+ interning
  where Arc::from was still used)
- /status.php and /openapi.json memoized into OnceLock<Bytes> (openapi
  rebuilt a 171 KiB spec per request: 2.8 ms → 18 ns)
- NC upload-session PROPFIND: write! + pre-sized body + stack RFC2822
  dates (2.3-2.6x, 2582→772 allocs at 256 chunks)
- REST download: dead FileDto clone removed (capture mime/size + move)
- CalendarEventDto/TrashedItem into_parts moves (11 KiB ical_data memcpy
  gone per CalDAV row); CardDAV getlastmodified stack render
- 4xx path: borrowed ErrorResponse serialize, ErrorKind::as_str,
  not_found/already_exists clone kill
- vCard emit via write!; search page moved out with into_iter skip/take;
  content-hit UUIDs parsed once; group last-user check via HashSet
- RateLimiter: lock-free get + insert (and_upsert_with variant REJECTED
  by benchmark); CSRF token borrow-compare + borrowed cookie extraction
- Thumbnail/preview ETags built from as_str (Debug-identical bytes)
- Encrypted backend: encrypt_in_place_detached single-buffer write path,
  chunk-sized reserve in collect_stream; retry labels made lazy
- PG: deferred upload registration 3→1 round-trips (persist_file CTE
  template); direct_grant_cache for Calendar/AddressBook/Playlist authz
  (single-flight + set_role/clear_role invalidation); expand_user
  tokio::join!; geo clusters min(uuid)::text; recluster face assignment
  batched into one UNNEST update
- People recluster cosine: norms precomputed once (bit-identical gate)
- NC capabilities poll logs demoted to debug; tracing-appender dep added
  for the log-writer benchmark

Frontend:
- ResourceList.selectedEntries O(N)-per-toggle → id-index projection
  O(k log k); favorites/recent consume the batchToolbar snippet param and
  drop their duplicate filter + dead selectedIds mirror
- Recent: star state via new favoriteIds prop — a star click no longer
  rebuilds all N entries
- admin timeAgo >30d fallback uses the cached Intl.DateTimeFormat
- vitest gates in src/lib/components/round11.bench.test.ts

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01ABhTEHuGujvwoodh67Kga7
This commit is contained in:
Claude
2026-07-18 22:02:00 +00:00
parent 637478e7bd
commit 221c1f31b0
54 changed files with 4060 additions and 630 deletions
@@ -119,6 +119,15 @@
onopen?: (entry: ResourceEntry) => void;
/** Per-entry favorite star toggle. */
onfavorite?: (entry: ResourceEntry) => void;
/**
* Live favorite-id set for the star state. When provided, the star
* reads membership here instead of `entry.isFavorite`, so a toggle
* repaints one star instead of forcing the host to rebuild every
* entry object (the Recent page paid a full O(N) re-map + re-render
* per star click through its `favoriteIds.has()` inside the entry
* mapper — see benches/ROUND11.md).
*/
favoriteIds?: ReadonlySet<string> | null;
/** Selection changed (set of selected entry ids). */
onselectionchange?: (ids: Set<string>) => void;
actions?: Snippet<[ResourceEntry]>;
@@ -156,6 +165,7 @@
onreload,
onopen,
onfavorite,
favoriteIds = null,
onselectionchange,
actions,
toolbar,
@@ -252,7 +262,22 @@
onselectionchange?.(selected);
}
}
const selectedEntries = $derived(items.filter((i) => selected.has(i.id)));
// Index rebuilt only when `items` changes; the projection below is then
// O(k · log k) in the selection size k instead of the old O(N) full-list
// `items.filter(...)` re-scan on every toggle (O(N²)-ish across a
// shift-range gesture once the batch toolbar was mounted). Item order is
// preserved via the index sort so the toolbar sees the same array the
// filter produced.
const itemIndexById = $derived(new Map(items.map((i, idx) => [i.id, idx])));
const selectedEntries = $derived.by(() => {
const picked: { idx: number; item: ResourceEntry }[] = [];
for (const id of selected) {
const idx = itemIndexById.get(id);
if (idx !== undefined) picked.push({ idx, item: items[idx] });
}
picked.sort((a, b) => a.idx - b.idx);
return picked.map((p) => p.item);
});
// Drop selection ids that are no longer present after a reload.
$effect(() => {
@@ -380,18 +405,19 @@
</span>
</div>
{#if onfavorite}
{@const starred = favoriteIds ? favoriteIds.has(entry.id) : !!entry.isFavorite}
<button
class="rl-star"
class:rl-star--on={entry.isFavorite}
class:rl-star--on={starred}
data-testid={`resource-list-favorite-${entry.id}-btn`}
title={entry.isFavorite
title={starred
? t('files.unfavorite', 'Remove favorite')
: t('files.favorite', 'Add favorite')}
aria-pressed={!!entry.isFavorite}
aria-pressed={starred}
onclick={(e) => {
e.stopPropagation();
onfavorite(entry);
}}><Icon name={entry.isFavorite ? 'star' : 'star-outline'} /></button
}}><Icon name={starred ? 'star' : 'star-outline'} /></button
>
{/if}
{#if actions}