From 276b9ff04ce881c66aa3b7ac380d11f847d73ff4 Mon Sep 17 00:00:00 2001 From: Edouard Vanbelle Date: Wed, 25 Mar 2026 17:03:36 +0100 Subject: [PATCH] refactor: remove duplicate code to handle home folder in bread crumb --- static/js/app/ui.js | 29 +++++------------------------ 1 file changed, 5 insertions(+), 24 deletions(-) diff --git a/static/js/app/ui.js b/static/js/app/ui.js index e4557a0f..32d6f098 100755 --- a/static/js/app/ui.js +++ b/static/js/app/ui.js @@ -516,34 +516,15 @@ const ui = { } breadcrumb.appendChild(homeIcon); - // -- Root/Home folder name (if available) -- + // -- Root/Home folder name (if available) is always the first element of the breadcrumb -- + // TODO clarify the difference between homeIcon & this first element if (window.app.userHomeFolderName) { - const separator1 = document.createElement('span'); - separator1.className = 'breadcrumb-separator'; - separator1.textContent = '>'; - breadcrumb.appendChild(separator1); - - const rootFolderItem = document.createElement('span'); - rootFolderItem.className = 'breadcrumb-item'; - rootFolderItem.textContent = window.app.userHomeFolderName; - - // If we're at the home folder level (no deeper navigation), show as current - if (path.length === 0) { - rootFolderItem.classList.add('breadcrumb-current'); - } else { - // Otherwise clickable to go back to home - rootFolderItem.classList.add('breadcrumb-link'); - rootFolderItem.addEventListener('click', () => { - window.app.breadcrumbPath = []; - window.app.currentPath = window.app.userHomeFolderId; - self.updateBreadcrumb(); - window.loadFiles(); - }); + if (path.length === 0 || path[0].id !== window.app.userHomeFolderId) { + path.unshift({ name: window.app.userHomeFolderName, id: window.app.userHomeFolderId}); } - breadcrumb.appendChild(rootFolderItem); } - // -- Intermediate + current segments -- + // -- Root/Home + Intermediate + current segments -- path.forEach((segment, index) => { const isLast = index === path.length - 1;