perf: use Arc<str> for repetitive DTO fields to eliminate clone allocations

Replace String with Arc<str> for fields that contain repeated static
values (mime_type, icon_class, icon_special_class, category) in
FileDto, FolderDto, and OptimizedFileContent.

These fields are computed from ~40 static lookup tables and cloned
on every request. With Arc<str>, clone becomes O(1) atomic increment
instead of O(n) heap allocation — saving thousands of allocations/s
under load.

Fields kept as String: id, name, path, folder_id, owner_id
(unique per item, rarely cloned).

Zero API impact — serde serializes Arc<str> identically to String.

https://claude.ai/code/session_01EbAFEfyJNLRmJHmmYDX3Tt
This commit is contained in:
Claude
2026-03-03 15:55:15 +00:00
parent 4bee05c690
commit 78c983136f
9 changed files with 52 additions and 47 deletions
+12 -10
View File
@@ -1,3 +1,5 @@
use std::sync::Arc;
use crate::domain::entities::folder::Folder;
use serde::{Deserialize, Serialize};
@@ -53,15 +55,15 @@ pub struct FolderDto {
/// Whether this is a root folder
pub is_root: bool,
// ── Pre-computed display fields ──
// ── Pre-computed display fields (Arc<str>: always identical values) ──
/// FontAwesome icon CSS class (always "fas fa-folder")
pub icon_class: String,
pub icon_class: Arc<str>,
/// Extra CSS class for icon styling (always "folder-icon")
pub icon_special_class: String,
pub icon_special_class: Arc<str>,
/// Human-readable category (always "Folder")
pub category: String,
pub category: Arc<str>,
}
impl From<Folder> for FolderDto {
@@ -77,9 +79,9 @@ impl From<Folder> for FolderDto {
created_at: folder.created_at(),
modified_at: folder.modified_at(),
is_root,
icon_class: "fas fa-folder".to_string(),
icon_special_class: "folder-icon".to_string(),
category: "Folder".to_string(),
icon_class: Arc::from("fas fa-folder"),
icon_special_class: Arc::from("folder-icon"),
category: Arc::from("Folder"),
}
}
}
@@ -112,9 +114,9 @@ impl FolderDto {
created_at: 0,
modified_at: 0,
is_root: true,
icon_class: "fas fa-folder".to_string(),
icon_special_class: "folder-icon".to_string(),
category: "Folder".to_string(),
icon_class: Arc::from("fas fa-folder"),
icon_special_class: Arc::from("folder-icon"),
category: Arc::from("Folder"),
}
}
}