diff --git a/static/js/app/filesView.js b/static/js/app/filesView.js index 3f8078b7..317ee069 100644 --- a/static/js/app/filesView.js +++ b/static/js/app/filesView.js @@ -79,13 +79,12 @@ async function rebuildBreadCrumb() { currentFolderInfo = folderInfo; } - // XXX do not enter root into bread crumb updateBreadcrumb() method always display it - if (!folderInfo.is_root) { - app.breadcrumbPath.unshift({ - id: folderInfo.id, - name: folderInfo.name - }); - } + // Add every folder to the breadcrumb, including the root (home folder). + // updateBreadcrumb() no longer auto-prepends home — it's our responsibility here. + app.breadcrumbPath.unshift({ + id: folderInfo.id, + name: folderInfo.name + }); // iterate to parent folder id = folderInfo.parent_id; diff --git a/static/js/app/ui.js b/static/js/app/ui.js index 9d721e37..24b7008b 100644 --- a/static/js/app/ui.js +++ b/static/js/app/ui.js @@ -574,18 +574,11 @@ const ui = { } breadcrumb?.appendChild(homeIcon); - // -- Root/Home folder name (if available) is always the first element of the breadcrumb -- - // TODO clarify the difference between homeIcon & this first element - if (app.userHomeFolderName) { - if (path.length === 0 || path[0].id !== app.userHomeFolderId) { - path.unshift({ - name: app.userHomeFolderName, - id: app.userHomeFolderId - }); - } - } - // -- Root/Home + Intermediate + current segments -- + // NOTE: The home folder entry is added by rebuildBreadCrumb() (filesView.js) when it + // reaches the root folder during traversal. updateBreadcrumb() just renders app.breadcrumbPath + // as-is — no implicit mutation. This allows shared-folder navigation to show only the + // reachable subtree without the home prefix leaking in. path.forEach((segment, index) => { const isLast = index === path.length - 1;