cjw/Oxicloud
1
0
Fork 0
Code Issues Pull Requests Actions 4 Packages Projects Releases Wiki Activity

style: apply linter suggestions

Browse Source
This commit is contained in:
Edouard Vanbelle
2026-04-07 22:50:42 +02:00
parent 1ce29c101d
commit a4266a6e93
33 changed files with 444 additions and 437 deletions
Download Patch File Download Diff File Expand all files Collapse all files
static/js/features/files/contextMenus.js
+12 -11
View File
@@ -25,9 +25,9 @@ const contextMenus = {
const wopiEditTab = document.getElementById('wopi-edit-file-tab-option');
if (!wopiEdit || !wopiEditTab) return;
const targetFile = window.app && window.app.contextMenuTargetFile;
const targetFile = window.app?.contextMenuTargetFile;
// Don't show WOPI editor for image files - they should use inline preview
const isImage = targetFile && targetFile.mime_type && targetFile.mime_type.startsWith('image/');
const isImage = targetFile?.mime_type?.startsWith('image/');
const show = targetFile && !isImage && window.wopiEditor && (await window.wopiEditor.canEdit(targetFile.name));
wopiEdit.classList.toggle('hidden', !show);
@@ -37,8 +37,8 @@ const contextMenus = {
syncFavoriteOptionLabels() {
if (!window.favorites) return;
const targetFile = window.app && window.app.contextMenuTargetFile;
const targetFolder = window.app && window.app.contextMenuTargetFolder;
const targetFile = window.app?.contextMenuTargetFile;
const targetFolder = window.app?.contextMenuTargetFolder;
if (targetFile) {
const isFav = window.favorites.isFavorite(targetFile.id, 'file');
@@ -68,7 +68,7 @@ const contextMenus = {
const folder = window.app.contextMenuTargetFolder;
// Check if folder is already in favorites to toggle
if (window.favorites && window.favorites.isFavorite(folder.id, 'folder')) {
if (window.favorites?.isFavorite(folder.id, 'folder')) {
// Remove from favorites
const ok = await window.favorites.removeFromFavorites(folder.id, 'folder');
if (ok && window.ui && typeof window.ui.setFavoriteVisualState === 'function') {
@@ -127,7 +127,7 @@ const contextMenus = {
.then((response) => response.json())
.then((fileDetails) => {
// Check if viewable file type (images, PDFs, text files)
if (window.ui && window.ui.isViewableFile(fileDetails)) {
if (window.ui?.isViewableFile(fileDetails)) {
// Open with inline viewer
if (window.inlineViewer) {
window.inlineViewer.openFile(fileDetails);
@@ -177,7 +177,7 @@ const contextMenus = {
const file = window.app.contextMenuTargetFile;
// Check if file is already in favorites to toggle
if (window.favorites && window.favorites.isFavorite(file.id, 'file')) {
if (window.favorites?.isFavorite(file.id, 'file')) {
// Remove from favorites
const ok = await window.favorites.removeFromFavorites(file.id, 'file');
if (ok && window.ui && typeof window.ui.setFavoriteVisualState === 'function') {
@@ -273,7 +273,7 @@ const contextMenus = {
const fileIds = items.filter((i) => i.type === 'file').map((i) => i.id);
const folderIds = items.filter((i) => i.type === 'folder').map((i) => i.id);
let result = await window.fileOps.batchCopy(fileIds, folderIds, targetId);
const result = await window.fileOps.batchCopy(fileIds, folderIds, targetId);
this.closeMoveDialog();
window.multiSelect.clear();
@@ -306,7 +306,7 @@ const contextMenus = {
const fileIds = items.filter((i) => i.type === 'file').map((i) => i.id);
const folderIds = items.filter((i) => i.type === 'folder' && i.id !== targetId).map((i) => i.id);
let result = await window.fileOps.batchMove(fileIds, folderIds, targetId);
const result = await window.fileOps.batchMove(fileIds, folderIds, targetId);
this.closeMoveDialog();
window.multiSelect.clear();
@@ -664,7 +664,7 @@ const contextMenus = {
window.app.selectedTargetFolderId = parentFolderId || '';
// Translate new elements
if (window.i18n && window.i18n.translateElement) {
if (window.i18n?.translateElement) {
window.i18n.translateElement(folderSelectContainer);
}
} catch (error) {
@@ -675,7 +675,7 @@ const contextMenus = {
/**
* Render breadcrumb navigation for move dialog
*/
_renderMoveDialogBreadcrumb(container, breadcrumb, currentFolderId) {
_renderMoveDialogBreadcrumb(container, breadcrumb, _currentFolderId) {
if (!container) return;
container.innerHTML = '';
@@ -757,6 +757,7 @@ const contextMenus = {
// Use loadMoveDialogFolders which uses /api/folders/{id}/contents
await this.loadMoveDialogFolders(window.app.userHomeFolderId || null);
},
/**
* Show share dialog for files or folders
* @param {Object} item - File or folder object
static/js/features/files/fileOperations.js
+10 -10
View File
@@ -350,7 +350,7 @@ const fileOps = {
// Legacy dropzone bar
if (progressBar) {
progressBar.style.width = (uploadedCount / totalFiles) * 100 + '%';
progressBar.style.width = `${(uploadedCount / totalFiles) * 100}%`;
}
// Notify bell of per-file completion
if (window.notifications && batchId) {
@@ -601,7 +601,7 @@ const fileOps = {
result = await this._uploadFileFetch(formData, thisTimeout);
console.log(`[UPLOAD END] #${idx} ${rel} ok=${result.ok}${result.errorMsg ? ' err=' + result.errorMsg : ''}`);
console.log(`[UPLOAD END] #${idx} ${rel} ok=${result.ok}${result.errorMsg ? ` err=${result.errorMsg}` : ''}`);
} catch (e) {
result = {
ok: false,
@@ -618,7 +618,7 @@ const fileOps = {
} catch (_) {}
}
if (progressBar && uploadedCount % 10 === 0) {
progressBar.style.width = (uploadedCount / totalFiles) * 100 + '%';
progressBar.style.width = `${(uploadedCount / totalFiles) * 100}%`;
}
if (uploadedCount % 50 === 0 || uploadedCount === totalFiles) {
console.log(`Progress: ${uploadedCount}/${totalFiles} (${successCount} ok)`);
@@ -748,7 +748,7 @@ const fileOps = {
try {
const errorData = await response.json();
errorMessage = errorData.error || 'Unknown error';
} catch (e) {
} catch (_e) {
errorMessage = 'Error processing server response';
}
window.ui.showNotification('Error', `Error moving the file: ${errorMessage}`);
@@ -790,7 +790,7 @@ const fileOps = {
try {
const errorData = await response.json();
errorMessage = errorData.error || 'Unknown error';
} catch (e) {
} catch (_e) {
errorMessage = 'Error processing server response';
}
window.ui.showNotification('Error', `Error moving the folder: ${errorMessage}`);
@@ -808,7 +808,7 @@ const fileOps = {
* @property {number} success number of files|folders sucessfully updated
* @property {number} errors number of files|folders in error
* /
/**
* Move files & folders
* @param {string[]} fileIds - File IDs
@@ -883,7 +883,7 @@ const fileOps = {
});
if (response.ok) {
const result = await response.json();
await response.json();
// Reload files after copying
await window.loadFiles();
window.ui.showNotification('File copied', 'File copied successfully');
@@ -893,7 +893,7 @@ const fileOps = {
try {
const errorData = await response.json();
errorMessage = errorData.error || 'Unknown error';
} catch (e) {
} catch (_e) {
errorMessage = 'Error processing server response';
}
window.ui.showNotification('Error', `Error copying the file: ${errorMessage}`);
@@ -997,7 +997,7 @@ const fileOps = {
try {
const errorData = JSON.parse(errorText);
errorMessage = errorData.error || response.statusText;
} catch (e) {
} catch (_e) {
errorMessage = errorText || response.statusText;
}
window.ui.showNotification('Error', `Error renaming the file: ${errorMessage}`);
@@ -1043,7 +1043,7 @@ const fileOps = {
// Try to parse as JSON
const errorData = JSON.parse(errorText);
errorMessage = errorData.error || response.statusText;
} catch (e) {
} catch (_e) {
// If not JSON, use text as is
errorMessage = errorText || response.statusText;
}
static/js/features/files/inlineViewer.js
+89 -89
View File
@@ -96,7 +96,7 @@ class InlineViewer {
// Detect images by mime type OR extension (uploads via WebDAV may lack correct mime)
const ext = (file.name || '').split('.').pop().toLowerCase();
const imageExts = ['jpg', 'jpeg', 'png', 'gif', 'svg', 'webp', 'bmp', 'ico', 'heic', 'heif', 'avif', 'tiff'];
const isImage = (file.mime_type && file.mime_type.startsWith('image/')) || imageExts.includes(ext);
const isImage = file.mime_type?.startsWith('image/') || imageExts.includes(ext);
if (!isImage && window.wopiEditor && (await window.wopiEditor.canEdit(file.name))) {
try {
window.wopiEditor.openInModal(file.id, file.name, 'edit');
@@ -159,7 +159,7 @@ class InlineViewer {
// Create text viewer using authenticated fetch
this.createTextViewer(file, container, loader);
} else if (file.mime_type && file.mime_type.startsWith('audio/')) {
} else if (file.mime_type?.startsWith('audio/')) {
// Hide zoom controls for audio
controls.style.display = 'none';
@@ -171,7 +171,7 @@ class InlineViewer {
// Create audio player
this.createMediaViewer(file, 'audio', container, loader);
} else if (file.mime_type && file.mime_type.startsWith('video/')) {
} else if (file.mime_type?.startsWith('video/')) {
// Hide zoom controls for video
controls.style.display = 'none';
@@ -225,7 +225,7 @@ class InlineViewer {
const text = await response.text();
// Remove loader
if (loader && loader.parentNode) {
if (loader?.parentNode) {
loader.parentNode.removeChild(loader);
}
@@ -240,7 +240,7 @@ class InlineViewer {
console.error('Error creating text viewer:', error);
// Remove loader
if (loader && loader.parentNode) {
if (loader?.parentNode) {
loader.parentNode.removeChild(loader);
}
@@ -284,8 +284,8 @@ class InlineViewer {
// e.loaded and e.total are JavaScript numbers (64-bit float)
const progress = e.loaded / e.total;
const pct = Math.round(progress * 100);
progressBar.style.width = pct + '%';
progressText.textContent = pct + '%';
progressBar.style.width = `${pct}%`;
progressText.textContent = `${pct}%`;
}
};
@@ -299,7 +299,7 @@ class InlineViewer {
}
};
xhr.onerror = function () {
xhr.onerror = () => {
reject(new Error('Network error'));
};
@@ -310,10 +310,10 @@ class InlineViewer {
const blob = response;
const blobUrl = URL.createObjectURL(blob);
console.log('Created blob URL:', blobUrl.substring(0, 30) + '...');
console.log('Created blob URL:', `${blobUrl.substring(0, 30)}...`);
// Remove loader
if (loader && loader.parentNode) {
if (loader?.parentNode) {
loader.parentNode.removeChild(loader);
}
@@ -369,7 +369,7 @@ class InlineViewer {
console.error('Error creating blob URL viewer:', error);
// Remove loader
if (loader && loader.parentNode) {
if (loader?.parentNode) {
loader.parentNode.removeChild(loader);
}
@@ -395,7 +395,7 @@ class InlineViewer {
const blobUrl = URL.createObjectURL(blob);
// Remove loader
if (loader && loader.parentNode) {
if (loader?.parentNode) {
loader.parentNode.removeChild(loader);
}
@@ -472,7 +472,7 @@ class InlineViewer {
} catch (error) {
console.error(`Error creating ${mediaType} viewer:`, error);
if (loader && loader.parentNode) {
if (loader?.parentNode) {
loader.parentNode.removeChild(loader);
}
@@ -492,85 +492,85 @@ class InlineViewer {
<p>Try downloading it directly.</p>
</div>
`;
container.appendChild(message);
}
closeViewer() {
// Get modal
const modal = document.getElementById('inline-viewer-modal');
// stops audio/video before closing viewver
const media = modal.querySelector('audio, video');
if (media && !media.paused) media.pause();
// Hide modal
modal.classList.remove('active');
// Clean up blob URL if exists
if (this.currentBlobUrl) {
URL.revokeObjectURL(this.currentBlobUrl);
this.currentBlobUrl = null;
container.appendChild(message);
}
// clear
window.app.viewFile = null;
window.updateHistory(false);
closeViewer() {
// Get modal
const modal = document.getElementById('inline-viewer-modal');
// Clear references
this.currentFile = null;
}
downloadFile(file) {
fetch(`/api/files/${file.id}`, { credentials: 'same-origin' })
.then(res => {
if (!res.ok) throw new Error(`HTTP ${res.status}`);
return res.blob();
})
.then(blob => {
const url = URL.createObjectURL(blob);
const link = document.createElement('a');
link.href = url;
link.download = file.name;
document.body.appendChild(link);
link.click();
document.body.removeChild(link);
URL.revokeObjectURL(url);
})
.catch(err => console.error('Download error:', err));
}
zoomImage(factor) {
const container = document.querySelector('.inline-viewer-container');
const img = container.querySelector('.inline-viewer-image');
if (!img) return;
// Get current scale
let scale = img.dataset.scale ? parseFloat(img.dataset.scale) : 1.0;
// Apply zoom factor
scale *= factor;
// Limit scale
scale = Math.max(0.1, Math.min(5.0, scale));
// Save scale
img.dataset.scale = scale;
// Apply scale
img.style.transform = `scale(${scale})`;
}
resetZoom() {
const container = document.querySelector('.inline-viewer-container');
const img = container.querySelector('.inline-viewer-image');
if (!img) return;
// Reset scale
img.dataset.scale = 1.0;
img.style.transform = 'scale(1.0)';
}
// stops audio/video before closing viewver
const media = modal.querySelector('audio, video');
if (media && !media.paused) media.pause();
// Hide modal
modal.classList.remove('active');
// Clean up blob URL if exists
if (this.currentBlobUrl) {
URL.revokeObjectURL(this.currentBlobUrl);
this.currentBlobUrl = null;
}
// clear
window.app.viewFile = null;
window.updateHistory(false);
// Clear references
this.currentFile = null;
}
downloadFile(file) {
fetch(`/api/files/${file.id}`, { credentials: 'same-origin' })
.then((res) => {
if (!res.ok) throw new Error(`HTTP ${res.status}`);
return res.blob();
})
.then((blob) => {
const url = URL.createObjectURL(blob);
const link = document.createElement('a');
link.href = url;
link.download = file.name;
document.body.appendChild(link);
link.click();
document.body.removeChild(link);
URL.revokeObjectURL(url);
})
.catch((err) => console.error('Download error:', err));
}
zoomImage(factor) {
const container = document.querySelector('.inline-viewer-container');
const img = container.querySelector('.inline-viewer-image');
if (!img) return;
// Get current scale
let scale = img.dataset.scale ? parseFloat(img.dataset.scale) : 1.0;
// Apply zoom factor
scale *= factor;
// Limit scale
scale = Math.max(0.1, Math.min(5.0, scale));
// Save scale
img.dataset.scale = scale;
// Apply scale
img.style.transform = `scale(${scale})`;
}
resetZoom() {
const container = document.querySelector('.inline-viewer-container');
const img = container.querySelector('.inline-viewer-image');
if (!img) return;
// Reset scale
img.dataset.scale = 1.0;
img.style.transform = 'scale(1.0)';
}
}
// Initialize viewer when document is ready
static/js/features/files/multiSelect.js
+16 -11
View File
@@ -72,8 +72,12 @@ const multiSelect = {
clear() {
this._selected.clear();
this._lastClickedIndex = -1;
document.querySelectorAll('.file-item.selected').forEach((el) => el.classList.remove('selected'));
document.querySelectorAll('.item-checkbox').forEach((cb) => (cb.checked = false));
document.querySelectorAll('.file-item.selected').forEach((el) => {
el.classList.remove('selected');
});
document.querySelectorAll('.item-checkbox').forEach((cb) => {
cb.checked = false;
});
this._syncUI();
},
@@ -103,8 +107,8 @@ const multiSelect = {
* @return {ItemSelection}
*/
getSelection(targtFolderId) {
let fileIds = [];
let folderIds = [];
const fileIds = [];
const folderIds = [];
// TODO optimize & check if _selected is a better use
document.querySelectorAll(`div.file-item.selected`).forEach((item) => {
@@ -155,7 +159,9 @@ const multiSelect = {
_selectAllInContainer(containerId, selector) {
const container = document.getElementById(containerId);
if (!container) return;
container.querySelectorAll(selector).forEach((el) => this._selectElement(el));
container.querySelectorAll(selector).forEach((el) => {
this._selectElement(el);
});
},
_getAllVisibleItems() {
@@ -190,7 +196,7 @@ const multiSelect = {
const info = this._extractInfo(el);
if (!info) return;
if (event && event.shiftKey && this._lastClickedIndex >= 0 && index >= 0) {
if (event?.shiftKey && this._lastClickedIndex >= 0 && index >= 0) {
const start = Math.min(this._lastClickedIndex, index);
const end = Math.max(this._lastClickedIndex, index);
for (let i = start; i <= end; i++) {
@@ -200,7 +206,7 @@ const multiSelect = {
const sel = iInfo.type === 'folder' ? `[data-folder-id="${iInfo.id}"]` : `[data-file-id="${iInfo.id}"]`;
document.querySelectorAll(sel).forEach((e) => {
e.classList.add('selected');
let checkbox = e.querySelector('input[type="checkbox"]');
const checkbox = e.querySelector('input[type="checkbox"]');
if (checkbox) checkbox.checked = true;
});
}
@@ -208,7 +214,7 @@ const multiSelect = {
} else {
const nowSelected = this.toggle(info.id, info.name, info.type, info.parentId);
el.classList.toggle('selected', nowSelected);
let checkbox = el.querySelector('input[type="checkbox"]');
const checkbox = el.querySelector('input[type="checkbox"]');
if (checkbox) checkbox.checked = nowSelected;
}
this._lastClickedIndex = index;
@@ -504,7 +510,7 @@ const multiSelect = {
const batchSelectionBar = document.getElementById('batch-selection-bar');
batchSelectionBar.innerHTML = this._buildSelectionBarHTML();
if (window.i18n && window.i18n.translateElement) {
if (window.i18n?.translateElement) {
window.i18n.translateElement(batchSelectionBar);
}
this._wireBarButtons();
@@ -512,10 +518,9 @@ const multiSelect = {
// FIXME: competition with _
_injectListHeaderCheckbox() {
const self = this;
const selectAllCheckbox = document.getElementById('select-all-checkbox');
if (!selectAllCheckbox) return;
selectAllCheckbox.addEventListener('change', () => self.toggleAll());
selectAllCheckbox.addEventListener('change', () => this.toggleAll());
}
};
static/js/features/files/search.js
+2 -2
View File
@@ -47,7 +47,7 @@ const search = {
try {
const errorJson = await response.json();
errorText = errorJson.error || response.statusText;
} catch (e) {
} catch (_e) {
errorText = response.statusText;
}
console.error(`Search error: ${errorText}`);
@@ -142,7 +142,7 @@ const search = {
if (sortSelect) {
sortSelect.addEventListener('change', () => {
const searchInput = document.querySelector('.search-container input');
if (searchInput && searchInput.value.trim()) {
if (searchInput?.value.trim()) {
const event = new CustomEvent('search-resort', {
detail: { sort_by: sortSelect.value }
});
static/js/features/files/wopiEditor.js
+21 -21
View File
@@ -17,8 +17,8 @@ class WopiEditor {
* Fetches supported extensions from the server (cached after first call).
*/
async canEdit(filename) {
var ext = filename.split('.').pop().toLowerCase();
var supported = await this._getSupportedExtensions();
const ext = filename.split('.').pop().toLowerCase();
const supported = await this._getSupportedExtensions();
return supported.includes(ext);
}
@@ -38,8 +38,8 @@ class WopiEditor {
async openInTab(fileId, fileName, action) {
action = action || 'edit';
try {
var data = await this._getEditorUrlWithFallback(fileId, fileName, action);
var hostUrl = '/wopi/edit/' + encodeURIComponent(fileId) + '?access_token=' + encodeURIComponent(data.access_token);
const data = await this._getEditorUrlWithFallback(fileId, fileName, action);
const hostUrl = `/wopi/edit/${encodeURIComponent(fileId)}?access_token=${encodeURIComponent(data.access_token)}`;
window.open(hostUrl, '_blank');
} catch (error) {
console.error('Failed to open WOPI editor in tab:', error);
@@ -53,12 +53,12 @@ class WopiEditor {
* Fetch editor URL and WOPI token from the backend.
*/
async _getEditorUrl(fileId, action) {
var response = await fetch('/api/wopi/editor-url?file_id=' + encodeURIComponent(fileId) + '&action=' + encodeURIComponent(action), {
const response = await fetch(`/api/wopi/editor-url?file_id=${encodeURIComponent(fileId)}&action=${encodeURIComponent(action)}`, {
credentials: 'same-origin'
});
if (!response.ok) {
var text = await response.text();
throw new Error('Editor URL request failed: ' + response.status + ' ' + text);
const text = await response.text();
throw new Error(`Editor URL request failed: ${response.status} ${text}`);
}
return response.json();
}
@@ -94,55 +94,55 @@ class WopiEditor {
_showModal(editorData, fileName) {
this.closeEditor();
var modal = document.createElement('div');
const modal = document.createElement('div');
modal.id = 'wopi-editor-modal';
modal.style.cssText = 'position:fixed;top:0;left:0;width:100%;height:100%;z-index:10000;background:#fff;';
var header = document.createElement('div');
const header = document.createElement('div');
header.style.cssText =
'height:40px;background:#333;color:#fff;display:flex;align-items:center;justify-content:space-between;padding:0 16px;font-family:sans-serif;font-size:14px;';
var title = document.createElement('span');
const title = document.createElement('span');
title.textContent = fileName;
header.appendChild(title);
var closeBtn = document.createElement('button');
const closeBtn = document.createElement('button');
closeBtn.textContent = '\u2715';
closeBtn.style.cssText = 'background:none;border:none;color:#fff;cursor:pointer;font-size:18px;padding:4px 8px;';
closeBtn.onclick = this.closeEditor.bind(this);
header.appendChild(closeBtn);
var form = document.createElement('form');
const form = document.createElement('form');
form.id = 'wopi_form';
form.target = 'wopi_frame';
form.action = editorData.editor_url;
form.method = 'post';
form.style.display = 'none';
var tokenInput = document.createElement('input');
const tokenInput = document.createElement('input');
tokenInput.name = 'access_token';
tokenInput.value = editorData.access_token;
tokenInput.type = 'hidden';
form.appendChild(tokenInput);
var ttlInput = document.createElement('input');
const ttlInput = document.createElement('input');
ttlInput.name = 'access_token_ttl';
ttlInput.value = editorData.access_token_ttl;
ttlInput.type = 'hidden';
form.appendChild(ttlInput);
var frameHolder = document.createElement('div');
const frameHolder = document.createElement('div');
frameHolder.style.cssText = 'position:absolute;top:40px;left:0;right:0;bottom:0;';
// Loading spinner (removed once the editor signals ready)
var spinner = document.createElement('div');
const spinner = document.createElement('div');
spinner.id = 'wopi-loading-spinner';
spinner.style.cssText =
'position:absolute;top:0;left:0;right:0;bottom:0;display:flex;align-items:center;justify-content:center;background:#f5f5f5;z-index:1;';
spinner.innerHTML = '<i class="fas fa-spinner fa-spin empty-state-icon spinner"></i>';
frameHolder.appendChild(spinner);
var iframe = document.createElement('iframe');
const iframe = document.createElement('iframe');
iframe.name = 'wopi_frame';
iframe.title = 'Document Editor';
iframe.style.cssText = 'width:100%;height:100%;border:none;';
@@ -175,9 +175,9 @@ class WopiEditor {
if (msgId === 'UI_Close' || msgId === 'close') {
this.closeEditor();
} else if (msgId === 'App_LoadingStatus') {
var status = data.Values && data.Values.Status;
const status = data.Values?.Status;
if (status === 'Document_Loaded' || status === 'Frame_Ready') {
var sp = document.getElementById('wopi-loading-spinner');
const sp = document.getElementById('wopi-loading-spinner');
if (sp) sp.remove();
}
}
@@ -225,9 +225,9 @@ class WopiEditor {
*/
async _fetchSupportedExtensions() {
try {
var response = await fetch('/wopi/supported-extensions');
const response = await fetch('/wopi/supported-extensions');
if (response.ok) {
var exts = await response.json();
const exts = await response.json();
if (Array.isArray(exts) && exts.length > 0) {
this._supportedExtensions = exts;
return exts;