perf: eliminate N+1 hot-path queries, cache immutable lookups, stop re-compressing compressed bytes
Every change is benchmark-verified (harness + before/after numbers in benches/, measured on this branch; reproduction commands in each doc): DAV / sync-client hot paths - PROPFIND dead-properties: one = ANY($1) query per 500-child page instead of one sequential query per child, and indexable `=` predicates instead of IS NOT DISTINCT FROM (seq scans). 2,000-child folder: 1.07-4.54 s of DB chatter -> 4-6 ms (258-773x). Applied to native + NC PROPFIND and both NC REPORT handlers. [benches/DEAD-PROPS.md] - Folder paging: keyset cursor (name > $last) + new partial index (folder_id, name) replaces LIMIT/OFFSET full-folder rescan per page. Full 20k-file walk: 1266 ms -> 77 ms (16.5x). New migration 20260917000000. [benches/PROPFIND-PAGING.md] - NC chroot / default-drive resolution: moka caches (30 s TTL, explicit invalidation on drive mutations) for find_default_for_user and the markerless chroot FolderDto. 2 uncached queries + 2 pool checkouts per NC/WebDAV/WOPI request -> sub-us moka hit (p50 0.7-3.6 ms -> ~1 us). [benches/CHROOT-CACHE.md] - Quota: PROPFINDs whose prop list never names a quota prop skip the 2-query resolution entirely (wants_quota()); the remaining lookups read 2 columns instead of the full auth.users row with its <=512 KiB avatar (11-16x, p50 3.4 ms -> 0.29 ms). Same narrow read now gates every upload quota check. [benches/QUOTA-PATH.md] CPU on the request path - ZIP exports (folder download, share ZIP, batch download): entries whose MIME says already-compressed (JPEG/MP4/zip/pdf/...) are Stored instead of Deflate - deflate ran inline on the tokio writer task at ~41 MB/s for ~0% size gain. Mixed media corpus: 4.31x wall and CPU, archive size unchanged. Shared predicate in common::mime_detect. [benches/ZIP-MEDIA.md] - Compression layers: tower-http's default maps to Brotli QUALITY 11 (verified in brotli-8.0.2 source and empirically: 90 ms per 64 KiB JSON response, 1.3 s per 700 KiB bundle). Both layers pinned to Precise(4): 99x less CPU for ~15% more bytes. SPA assets are now precompressed at build time (scripts/precompress.mjs, 77% smaller) and served via ServeDir::precompressed_br/gzip: 2016x less per-request work, and clients get the better q11 bytes. [benches/STATIC-PRECOMPRESSED.md] Batched / cached backend paths [benches/NPLUS1-AND-CACHES.md] - Content-search ReBAC re-verification: new AuthorizationEngine::check_files_read_batch (default = old loop; PgAclEngine override batches drive resolution + reuses role cache). 200 sequential point SELECTs per search -> 1-2 queries. - Batch-ZIP subtree downloads: drop per-file re-authz + per-file Recent recording (2 writes/file) for subtree entries already authorized at the root - mirrors the native folder-download path. ~6,000 statements removed from a 2,000-file archive. - CDC chunk manifests: immutable by content address, now moka-cached (weight-bounded 32 MiB, 60 s TTL, positive-only, invalidated on delete) - removes one manifest query (p50 0.44-4.4 ms) from every stream, range and full blob read. - People tab: grouped COUNT + batched cover lookup instead of dragging every face row with its 2 KiB embedding (10k faces: 30.4 ms & 21 MB -> 3.8 ms & 1.3 KB, 8.1x); merge() is one set-based UPDATE. [benches/PEOPLE-LIST.md] - Photos timeline cursor: raw timestamptz comparison instead of EXTRACT(EPOCH ...) wrapper + IS NULL OR disjunction - cursor is an index boundary again, deep scroll stops re-scanning skipped rows. - Public share landing: one atomic UPDATE ... access_count + 1 (was SELECT + full-row write-back: racy, lost updates, clobbered concurrent owner edits) - 3 round-trips -> 2 per visit. - move_to_trash: dead full-entity SELECT feeding a documented no-op removed from both branches; dead fields dropped from TrashService. - NFC normalization: is_nfc_quick fast path skips the decompose/recompose state machine for the ~100% already-NFC case (every row loaded from PG). Frontend - Large folders paint after page one (~200 items) via fetchFolderListing's new onPage hook instead of waiting for every sequential page. - Tested-and-reverted (kept for the record): cached Intl.Collator for name sorts - vitest showed it 2x SLOWER than V8's argument-less localeCompare fast path (5.6 ms vs 12.1 ms / 5k names). Sort order untouched. New bench harnesses under examples/ (bench feature): zip_media, dead_props, chroot_cache, quota_path, people_list, propfind_paging, static_precompress. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CBK1RdtzyP6759Muqe1K1w
This commit is contained in:
@@ -0,0 +1,57 @@
|
||||
# WebDAV dead-properties — batched per-page fetch (vs per-child N+1)
|
||||
|
||||
The streaming PROPFIND walkers (native `webdav_handler.rs`, NextCloud
|
||||
`nextcloud/webdav_handler.rs`, plus both NC REPORT handlers) fetched dead
|
||||
properties **one child at a time, sequentially** — one DB round-trip per file
|
||||
and per subfolder of every Depth:1 listing. On top, every
|
||||
`DeadPropertyStore` query filtered with `folder_id IS NOT DISTINCT FROM $1 AND
|
||||
file_id IS NOT DISTINCT FROM $2`, which PostgreSQL cannot serve from a B-tree
|
||||
index (`IS NOT DISTINCT FROM` is not an indexable operator) — so each of those
|
||||
N round-trips also degraded to a **sequential scan** as the table grew.
|
||||
|
||||
Changes:
|
||||
|
||||
1. `DeadPropertyStore::get_all_for_files / get_all_for_folders` — ONE
|
||||
`file_id = ANY($1)` round-trip per 500-child PROPFIND page (indexable via
|
||||
the partial unique indexes from migration 20260830000001).
|
||||
2. All single-resource queries (`get`, `get_all`, `remove`) now filter on the
|
||||
concrete column (`file_id = $1` / `folder_id = $1`) instead of the
|
||||
NULL-tolerant pair — index scans instead of seq scans.
|
||||
3. All four handler loops replaced with one batched map lookup per page.
|
||||
|
||||
## Reproduce
|
||||
|
||||
```bash
|
||||
cargo run --release --features bench --example bench_dead_props
|
||||
# tunables: BENCH_CHILDREN=2000 BENCH_PAGE=500 BENCH_NOISE_ROWS=20000 BENCH_REPS=5
|
||||
```
|
||||
|
||||
Measures exactly the dead-prop portion of one Depth:1 PROPFIND of a
|
||||
2,000-child folder (what the walker adds on top of the listing queries).
|
||||
|
||||
## Results (4 cores, local PG16, this container)
|
||||
|
||||
**Table with only the 2,000 seeded rows:**
|
||||
|
||||
| mode | queries | total ms | vs OLD |
|
||||
|-------------------------------|--------:|---------:|-------:|
|
||||
| OLD — seq, IS NOT DISTINCT | 2000 | 1072.41 | 1.0× |
|
||||
| EQ — seq, `file_id = $1` | 2000 | 509.89 | 2.1× |
|
||||
| BATCH — `= ANY($1)` per page | 4 | 4.15 | **258×** |
|
||||
|
||||
**Table with 22,000 rows (realistic volume — seq scans hurt):**
|
||||
|
||||
| mode | queries | total ms | vs OLD |
|
||||
|-------------------------------|--------:|---------:|-------:|
|
||||
| OLD — seq, IS NOT DISTINCT | 2000 | 4543.74 | 1.0× |
|
||||
| EQ — seq, `file_id = $1` | 2000 | 515.84 | 8.8× |
|
||||
| BATCH — `= ANY($1)` per page | 4 | 5.88 | **773×** |
|
||||
|
||||
- A Depth:1 PROPFIND of a 2,000-child folder was spending **1.1–4.5 s** on
|
||||
dead-prop chatter alone — now **~5 ms**. This is per folder per sync poll,
|
||||
on the hottest path desktop sync clients have.
|
||||
- The `EQ` row isolates the indexability fix (2.1–8.8×); the batching is the
|
||||
rest. Both are applied.
|
||||
- Same unit economics apply to the other N+1s fixed alongside (search ReBAC
|
||||
batch, ZIP batch authz): each eliminated sequential point query is worth
|
||||
~0.25–2.3 ms of the numbers above depending on table size.
|
||||
Reference in New Issue
Block a user