feat(consistency): satellites_consistency covers both tables, and the sweep covers every job
Extends the derived check to `file_attached_blobs` and renames it, since the two tables are one concept — the content-keyed and file-keyed halves of "things attached to a Blob" — and `storage.copy_file_satellites` already established the vocabulary. The attached half is the one that cannot be recovered. `attached_dangling_blob` is data_loss with `recoverable: false`: those bytes were user-supplied and have no server-side render path, so nothing can regenerate them. Its derived twin carries `recoverable: true`, because a derived artifact is a pure function of its source and re-rendering restores it. Same finding shape, materially different stakes, and the detail says which. No orphan-mapping check on the attached side, deliberately: `file_id` is ON DELETE CASCADE, so a row cannot outlive its file. The database enforces what the derived table cannot, since a content hash has no row to point a foreign key at — which is exactly why only that half could rot. One job walking two tables needs a phase in the cursor, or an attached checkpoint would be replayed against the derived table and silently re-scan or skip. Two things the sweep was missing, found while checking whether every consistency job is actually exercised: drives_consistency and folders_consistency were registered but never run by any test. Now included; the list is exhaustive by intent. An unknown job was a warning-and-skip. That protected feature-gated builds at the cost of something worse: this list said `derived_consistency` for one commit after the rename and would have dropped that coverage without a word, leaving the suite green over a check that no longer ran. It fails now.
This commit is contained in:
+3
-3
@@ -1494,13 +1494,13 @@ impl AppServiceFactory {
|
||||
.register_recoverable_job(&core.job_registry, &job_store_provider_dyn)
|
||||
.await;
|
||||
|
||||
// Finds derived mappings whose Blob is gone on either side. Nothing
|
||||
// else can: a row whose SOURCE was reaped still holds a valid
|
||||
// Both satellite tables, checked for mappings whose Blob is gone.
|
||||
// Nothing else can: a row whose SOURCE was reaped still holds a valid
|
||||
// reference to a real artifact with a correct refcount, so every
|
||||
// other check agrees the system is healthy while the artifact is
|
||||
// pinned forever. Read-only.
|
||||
let _ = Arc::new(
|
||||
crate::infrastructure::services::derived_consistency_service::DerivedConsistencyCheck::new(
|
||||
crate::infrastructure::services::satellites_consistency_service::SatellitesConsistencyCheck::new(
|
||||
maintenance_pool.clone(),
|
||||
),
|
||||
)
|
||||
|
||||
Reference in New Issue
Block a user