perf(storage): incremental per-upload usage update (O(1)) instead of full SUM

After every upload, maybe_update_storage_usage spawned a full
`SUM(size) OVER all the user's non-trashed files` to refresh
auth.users.storage_used_bytes — O(N) in the user's file count per upload,
i.e. O(N²) for a bulk upload. (The covering index makes it index-only but
still scans N rows.)

Replace it with an O(1) incremental `storage_used_bytes += size`, keyed by the
file's owner_id (dropping the brittle "My Folder - <user>" path-parsing hack).
Deletes/trash never decremented this value — they already rely on the periodic
reconciliation sweep — so the model is unchanged: the sweep remains the
correctness backstop for every mutation, and the counter is clamped at 0.
Both stay fire-and-forget on a background task, off the upload's latency path.

Benchmarked (per-call, vs the user's existing file count N):
  N=1k:  full-SUM 202us  vs incremental 123us
  N=10k: full-SUM 1185us vs incremental 113us   (10x)
  N=50k: full-SUM 5397us vs incremental 114us   (47x — incremental is flat O(1))
Bulk upload of 10k files (insert + usage update each):
  full-SUM (O(N²)) 10.37s  ->  incremental (O(N)) 4.89s   (>2x, diverges with scale)

https://claude.ai/code/session_01DCszkkU11LYxMEUWr4setK
This commit is contained in:
Claude
2026-06-15 12:27:22 +00:00
parent d69873297a
commit b5b80549ea
2 changed files with 54 additions and 38 deletions
@@ -102,6 +102,32 @@ impl StorageUsageService {
Ok(total_usage)
}
/// Incrementally adjust one user's cached usage by `delta` bytes — O(1),
/// the per-upload counterpart to the O(N) full recompute above. An upload
/// adds `+size` (was a full `SUM(size)` over every file the user owns, i.e.
/// O(N) per upload and O(N²) for a bulk upload). Deletes/trash do not
/// decrement here (they never did); the periodic reconciliation sweep
/// ([`StorageUsagePort::update_all_users_storage_usage`]) remains the
/// correctness backstop for every mutation. Clamped at 0 so a late or
/// duplicate adjustment can never drive the counter negative.
pub async fn add_user_storage_usage_delta(
&self,
user_id: Uuid,
delta: i64,
) -> Result<(), DomainError> {
sqlx::query(
"UPDATE auth.users
SET storage_used_bytes = GREATEST(0, storage_used_bytes + $2)
WHERE id = $1",
)
.bind(user_id)
.bind(delta)
.execute(self.pool.as_ref())
.await
.map_err(|e| DomainError::internal_error("StorageUsage", format!("usage delta: {e}")))?;
Ok(())
}
/// Spawn a background task that periodically reconciles every user's cached
/// `storage_used_bytes` against the actual sum of their files.
///