fix: fetch OIDC discovery before building authorization URL (#91)

get_authorize_url() was synchronous and fell back to constructing
{issuer}/authorize when the discovery cache was empty. This produced
incorrect URLs for providers like Keycloak whose authorization
endpoint is {issuer}/protocol/openid-connect/auth.

Made get_authorize_url() async so it can call get_discovery() to
fetch the real authorization_endpoint from .well-known/openid-configuration
before the first redirect. The discovery document is cached after the
initial fetch.
This commit is contained in:
Dionisio
2026-02-13 21:42:41 +01:00
parent 33ed3bd66c
commit c384a08763
4 changed files with 9 additions and 20 deletions
+4 -16
View File
@@ -238,22 +238,10 @@ impl OidcService {
#[async_trait]
impl OidcServicePort for OidcService {
fn get_authorize_url(&self, state: &str, nonce: &str, pkce_challenge: &str) -> Result<String, DomainError> {
// We need the authorization_endpoint. If not cached, we'll construct it from issuer.
// In practice, the discovery should be pre-fetched during startup.
let auth_endpoint = {
let cache = self.discovery.read().map_err(|_| DomainError::new(
ErrorKind::InternalError, "OIDC", "Lock poisoned",
))?;
match &*cache {
Some(disc) => disc.authorization_endpoint.clone(),
None => {
// Fallback: construct typical endpoint
let issuer = self.config.issuer_url.trim_end_matches('/');
format!("{}/authorize", issuer)
}
}
};
async fn get_authorize_url(&self, state: &str, nonce: &str, pkce_challenge: &str) -> Result<String, DomainError> {
// Fetch or use cached discovery to get the correct authorization_endpoint
let discovery = self.get_discovery().await?;
let auth_endpoint = discovery.authorization_endpoint;
let scopes = self.config.scopes.replace(',', " ");
let url = format!(