fix(bench): silence clippy neg_cmp_op_on_partial_ord in round25/26 gate helpers
The BEFORE/AFTER rollback gates wrote `if !(after < before)`, which clippy::neg_cmp_op_on_partial_ord flags on f64 (a negated comparison on a partially-ordered type). Under CI's `cargo clippy --all-targets -- -D warnings` this fails. Replace with the equivalent `if after >= before` (fail the gate when AFTER does not strictly beat BEFORE). No behavioral change to any benchmark. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01L8gs91AhmazoxMsDcNk3KT
This commit is contained in:
@@ -130,7 +130,7 @@ fn report(tag: &str, before: Measure, after: Measure) {
|
|||||||
|
|
||||||
/// Roll-back gate: `exit(1)` unless AFTER strictly beats BEFORE on `metric`.
|
/// Roll-back gate: `exit(1)` unless AFTER strictly beats BEFORE on `metric`.
|
||||||
fn gate(tag: &str, metric: &str, before: f64, after: f64) {
|
fn gate(tag: &str, metric: &str, before: f64, after: f64) {
|
||||||
if !(after < before) {
|
if after >= before {
|
||||||
eprintln!("GATE FAIL [{tag}] {metric}: AFTER {after} !< BEFORE {before} — rollback");
|
eprintln!("GATE FAIL [{tag}] {metric}: AFTER {after} !< BEFORE {before} — rollback");
|
||||||
std::process::exit(1);
|
std::process::exit(1);
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -54,7 +54,7 @@ fn report(tag: &str, unit: &str, before: f64, after: f64, stmts_before: usize, s
|
|||||||
}
|
}
|
||||||
|
|
||||||
fn gate(tag: &str, metric: &str, before: f64, after: f64) {
|
fn gate(tag: &str, metric: &str, before: f64, after: f64) {
|
||||||
if !(after < before) {
|
if after >= before {
|
||||||
eprintln!("GATE FAIL [{tag}] {metric}: AFTER {after} !< BEFORE {before} — rollback");
|
eprintln!("GATE FAIL [{tag}] {metric}: AFTER {after} !< BEFORE {before} — rollback");
|
||||||
std::process::exit(1);
|
std::process::exit(1);
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -34,7 +34,7 @@ fn env_or<T: std::str::FromStr>(key: &str, default: T) -> T {
|
|||||||
}
|
}
|
||||||
|
|
||||||
fn gate(tag: &str, metric: &str, before: f64, after: f64) {
|
fn gate(tag: &str, metric: &str, before: f64, after: f64) {
|
||||||
if !(after < before) {
|
if after >= before {
|
||||||
eprintln!("GATE FAIL [{tag}] {metric}: AFTER {after} !< BEFORE {before} — rollback");
|
eprintln!("GATE FAIL [{tag}] {metric}: AFTER {after} !< BEFORE {before} — rollback");
|
||||||
std::process::exit(1);
|
std::process::exit(1);
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -38,7 +38,7 @@ fn p50(mut s: Vec<f64>) -> f64 {
|
|||||||
}
|
}
|
||||||
|
|
||||||
fn gate(tag: &str, metric: &str, before: f64, after: f64) {
|
fn gate(tag: &str, metric: &str, before: f64, after: f64) {
|
||||||
if !(after < before) {
|
if after >= before {
|
||||||
eprintln!("GATE FAIL [{tag}] {metric}: AFTER {after} !< BEFORE {before} — rollback");
|
eprintln!("GATE FAIL [{tag}] {metric}: AFTER {after} !< BEFORE {before} — rollback");
|
||||||
std::process::exit(1);
|
std::process::exit(1);
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -110,7 +110,7 @@ fn report(tag: &str, before: Measure, after: Measure) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
fn gate(tag: &str, metric: &str, before: f64, after: f64) {
|
fn gate(tag: &str, metric: &str, before: f64, after: f64) {
|
||||||
if !(after < before) {
|
if after >= before {
|
||||||
eprintln!("GATE FAIL [{tag}] {metric}: AFTER {after} !< BEFORE {before} — rollback");
|
eprintln!("GATE FAIL [{tag}] {metric}: AFTER {after} !< BEFORE {before} — rollback");
|
||||||
std::process::exit(1);
|
std::process::exit(1);
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user