perf(frontend): add build.rs asset pipeline with oxc + lightningcss

- Bundle 31 JS files → single app.{hash}.js (oxc minifier)
- Bundle 36 CSS files → single app.{hash}.css (lightningcss)
- Resolve CSS @import chains at build time
- Inline theme-init.js to eliminate render-blocking script
- Minify all individual JS/CSS/JSON assets in static-dist/
- Auto-update Service Worker cache manifest with bundle hashes
- FNV hash-based cache-busting filenames

Results: 88 → 12 requests, 640 kB → 96.5 kB transferred (-85%)

Build modes:
- Debug: copies HTML to OUT_DIR, serves original static/
- Release: generates static-dist/ with processed assets

Also:
- Update Dockerfile to include build.rs in cacher stage
- Serve static-dist/ in release Docker builds
- Remove host static/ bind mount from docker-compose
- Switch include_str!() to OUT_DIR for all HTML pages
This commit is contained in:
Diocrafts
2026-03-08 13:10:38 +01:00
parent 75979d280a
commit f409a9edd7
8 changed files with 1669 additions and 38 deletions
+3
View File
@@ -2,6 +2,9 @@
/target/
**/target/
# Processed static assets (generated by build.rs in release mode)
/static-dist/
# Remove Cargo.lock from gitignore if creating an executable, leave it for libraries
# More information here https://doc.rust-lang.org/cargo/guide/cargo-toml-vs-cargo-lock.html
# Cargo.lock
Generated
+1088 -25
View File
File diff suppressed because it is too large Load Diff
+8
View File
@@ -63,6 +63,14 @@ integration_tests = []
[lints.rust]
unexpected_cfgs = { level = "warn", check-cfg = ['cfg(integration_tests)'] }
[build-dependencies]
oxc_allocator = "0.116"
oxc_parser = "0.116"
oxc_span = "0.116"
oxc_codegen = "0.116"
oxc_minifier = "0.116"
lightningcss = "1.0.0-alpha.70"
[profile.release]
lto = "fat"
codegen-units = 1
+8 -5
View File
@@ -4,11 +4,14 @@ WORKDIR /app
RUN apk --no-cache upgrade && \
apk add --no-cache musl-dev pkgconfig postgresql-dev gcc perl make
COPY Cargo.toml Cargo.lock ./
# build.rs + static/ are needed so the build script can run and set OUT_DIR
COPY build.rs ./
COPY static static
# Create a minimal project to download and cache dependencies
RUN mkdir -p src && \
echo 'fn main() { println!("Dummy build for caching dependencies"); }' > src/main.rs && \
RUSTFLAGS="-C target-cpu=native" cargo build --release && \
rm -rf src target/release/deps/oxicloud*
rm -rf src static-dist target/release/deps/oxicloud* target/release/build/oxicloud-*
# Stage 2: Build the application
FROM rust:1.94.0-alpine3.23 AS builder
WORKDIR /app
@@ -17,8 +20,8 @@ RUN apk --no-cache upgrade && \
# Copy cached dependencies (only target dir and cargo registry)
COPY --from=cacher /app/target target
COPY --from=cacher /usr/local/cargo/registry /usr/local/cargo/registry
# Copy source and static (login.html is embedded at compile-time via include_str!)
COPY Cargo.toml Cargo.lock ./
# Copy source, build script, and static assets
COPY Cargo.toml Cargo.lock build.rs ./
COPY src src
COPY static static
COPY db db
@@ -54,8 +57,8 @@ RUN chmod +x /usr/local/bin/oxicloud
COPY entrypoint.sh /usr/local/bin/entrypoint.sh
RUN chmod +x /usr/local/bin/entrypoint.sh
# Copy static files and other resources needed at runtime
COPY --chown=oxicloud:oxicloud static /app/static
# Copy processed static files (bundled/minified by build.rs in release)
COPY --from=builder --chown=oxicloud:oxicloud /app/static-dist /app/static
COPY --chown=oxicloud:oxicloud db /app/db
# Create storage directory with proper permissions
+537
View File
@@ -0,0 +1,537 @@
//! build.rs — Static-asset pipeline for OxiCloud
//!
//! **Release mode** (`cargo build --release`):
//! 1. Copies `static/` → `static-dist/` (processed mirror).
//! 2. Resolves CSS `@import` chains → flat `main.css`.
//! 3. Bundles all index.html CSS/JS → `app.{hash}.css` / `app.{hash}.js`.
//! 4. Minifies every `.css` (lightningcss) and `.js` (oxc).
//! 5. Rewrites `index.html` with bundled asset paths.
//! 6. Minifies locale JSON files.
//! 7. Updates `sw.js` cache manifest.
//! 8. Writes HTML files to `$OUT_DIR` for `include_str!()`.
//!
//! **Debug mode** (`cargo build`):
//! • Copies HTML files to `$OUT_DIR` for `include_str!()` only.
use std::fs;
use std::io;
use std::path::{Path, PathBuf};
// ─── HTML files embedded via include_str!() in Rust source ───────────────────
const HTML_INCLUDE: &[&str] = &[
"login.html",
"profile.html",
"admin.html",
"device-verify.html",
"nextcloud-login.html",
];
// ─── View CSS files linked directly in index.html (not via @import) ──────────
const INDEX_VIEW_CSS: &[&str] = &[
"views/inlineViewer.css",
"views/favorites.css",
"views/recent.css",
"views/shared.css",
"views/trash.css",
"views/photos.css",
"views/photosLightbox.css",
];
// ═══════════════════════════════════════════════════════════════════════════════
// Entry point
// ═══════════════════════════════════════════════════════════════════════════════
fn main() {
let manifest_dir = penv("CARGO_MANIFEST_DIR");
let out_dir = penv("OUT_DIR");
let static_dir = manifest_dir.join("static");
println!("cargo:rerun-if-changed=static");
println!("cargo:rerun-if-changed=build.rs");
// ── Guard: Docker cacher stage has no static/ ────────────────────────────
if !static_dir.exists() {
for name in HTML_INCLUDE {
let _ = fs::write(out_dir.join(name), "");
}
return;
}
let is_release = env_or("PROFILE", "debug") == "release";
if is_release {
process_release(&manifest_dir, &static_dir, &out_dir);
} else {
// Debug: copy original HTML for include_str!()
for name in HTML_INCLUDE {
let src = static_dir.join(name);
if src.exists() {
let _ = fs::copy(&src, out_dir.join(name));
}
}
}
}
// ═══════════════════════════════════════════════════════════════════════════════
// Release pipeline
// ═══════════════════════════════════════════════════════════════════════════════
fn process_release(manifest_dir: &Path, static_dir: &Path, out_dir: &Path) {
let dist_dir = manifest_dir.join("static-dist");
// Start fresh
if dist_dir.exists() {
fs::remove_dir_all(&dist_dir).expect("clean static-dist");
}
// 1. Mirror static/ → static-dist/
copy_dir_recursive(static_dir, &dist_dir).expect("copy static → static-dist");
let css_dir = static_dir.join("css");
// ── 2. Resolve main.css @imports ─────────────────────────────────────────
let resolved_main = resolve_css_imports(&css_dir.join("main.css"), &css_dir);
let minified_main = css_minify_safe(&resolved_main);
fs::write(dist_dir.join("css/main.css"), &minified_main).expect("write main.css");
// ── 3. Build CSS bundle for index.html ───────────────────────────────────
let mut css_all = resolved_main;
for view in INDEX_VIEW_CSS {
let p = css_dir.join(view);
if p.exists() {
css_all.push_str(&fs::read_to_string(&p).unwrap_or_default());
css_all.push('\n');
}
}
let css_bundle = css_minify_safe(&css_all);
let css_hash = fnv_hash(css_bundle.as_bytes());
let css_name = format!("app.{css_hash}.css");
fs::write(dist_dir.join("css").join(&css_name), &css_bundle).expect("write css bundle");
// ── 4. Minify ALL individual CSS in static-dist/ ─────────────────────────
minify_tree_css(&dist_dir.join("css"), &css_name);
// ── 5. Build JS bundle for index.html ────────────────────────────────────
let index_html = fs::read_to_string(static_dir.join("index.html")).expect("read index.html");
let defer_scripts = extract_defer_scripts(&index_html);
let js_bundle = build_js_bundle(static_dir, &defer_scripts);
let js_hash = fnv_hash(js_bundle.as_bytes());
let js_name = format!("app.{js_hash}.js");
fs::write(dist_dir.join("js").join(&js_name), &js_bundle).expect("write js bundle");
// ── 6. Minify ALL individual JS in static-dist/ ──────────────────────────
minify_tree_js(&dist_dir.join("js"), &js_name);
// ── 7. Inline theme-init.js & rewrite index.html ──────────────────────
let theme_init = fs::read_to_string(static_dir.join("js/core/theme-init.js"))
.unwrap_or_default();
let theme_init_min = js_minify_safe(&theme_init);
let rewritten_index = rewrite_index_html(
&index_html,
&format!("/css/{css_name}"),
&format!("/js/{js_name}"),
&theme_init_min,
);
fs::write(dist_dir.join("index.html"), &rewritten_index).expect("write dist index.html");
// ── 8. Minify locale JSONs ───────────────────────────────────────────────
minify_tree_json(&dist_dir.join("locales"));
// ── 9. Update & minify sw.js ─────────────────────────────────────────────
let sw = fs::read_to_string(dist_dir.join("sw.js")).unwrap_or_default();
let sw_updated = update_sw_cache(&sw, &css_name, &js_name);
let sw_minified = js_minify_safe(&sw_updated);
fs::write(dist_dir.join("sw.js"), &sw_minified).expect("write sw.js");
// ── 10. Write HTML for include_str!() to OUT_DIR ─────────────────────────
for name in HTML_INCLUDE {
let src = dist_dir.join(name);
if src.exists() {
let _ = fs::copy(&src, out_dir.join(name));
}
}
// index.html too (future use / embedded route)
fs::write(out_dir.join("index.html"), &rewritten_index).expect("write out index.html");
eprintln!(
"cargo:warning=OxiCloud static-dist built ✓ CSS: {css_name} JS: {js_name}"
);
}
// ═══════════════════════════════════════════════════════════════════════════════
// CSS processing
// ═══════════════════════════════════════════════════════════════════════════════
/// Resolve `@import url("…")` one level deep, returning concatenated CSS.
fn resolve_css_imports(entry: &Path, css_dir: &Path) -> String {
let content = fs::read_to_string(entry).unwrap_or_default();
let mut out = String::with_capacity(content.len() * 20);
for line in content.lines() {
let t = line.trim();
if t.starts_with("@import") {
if let Some(rel) = extract_import_path(t) {
let resolved = css_dir.join(rel.trim_start_matches("./"));
if resolved.exists() {
out.push_str(&fs::read_to_string(&resolved).unwrap_or_default());
out.push('\n');
} else {
eprintln!("cargo:warning=CSS import not found: {}", resolved.display());
}
}
} else if !t.is_empty() && !t.starts_with("/*") {
// Keep non-import, non-comment lines
out.push_str(line);
out.push('\n');
}
}
out
}
/// Extract the path from `@import url("./foo.css");` or `@import "./foo.css";`
fn extract_import_path(line: &str) -> Option<String> {
let s = line.find('"')? + 1;
let e = line[s..].find('"')? + s;
Some(line[s..e].to_string())
}
/// Minify CSS via lightningcss — returns original on failure.
fn css_minify_safe(source: &str) -> String {
css_minify(source).unwrap_or_else(|e| {
eprintln!("cargo:warning=CSS minify failed: {e}");
source.to_string()
})
}
fn css_minify(source: &str) -> Result<String, String> {
use lightningcss::stylesheet::{ParserOptions, PrinterOptions, StyleSheet};
let mut sheet = StyleSheet::parse(source, ParserOptions::default())
.map_err(|e| format!("{e}"))?;
sheet
.minify(Default::default())
.map_err(|e| format!("{e}"))?;
let res = sheet
.to_css(PrinterOptions {
minify: true,
..Default::default()
})
.map_err(|e| format!("{e}"))?;
Ok(res.code)
}
/// Walk a directory and minify every `.css` in-place (skips generated bundles).
fn minify_tree_css(dir: &Path, skip_prefix: &str) {
let Ok(entries) = fs::read_dir(dir) else { return };
for entry in entries.flatten() {
let p = entry.path();
if p.is_dir() {
minify_tree_css(&p, skip_prefix);
} else if p.extension().is_some_and(|e| e == "css") {
let fname = p.file_name().unwrap().to_string_lossy();
// Skip the generated bundle and already-processed main.css
if fname.starts_with("app.") || fname == "main.css" {
continue;
}
if let Ok(src) = fs::read_to_string(&p) {
let _ = fs::write(&p, css_minify_safe(&src));
}
}
}
}
// ═══════════════════════════════════════════════════════════════════════════════
// JS processing
// ═══════════════════════════════════════════════════════════════════════════════
/// Collect `<script defer src="…">` paths from HTML.
fn extract_defer_scripts(html: &str) -> Vec<String> {
html.lines()
.filter_map(|l| {
let t = l.trim();
if t.starts_with("<script") && t.contains("defer") && t.contains("src=\"") {
let s = t.find("src=\"")? + 5;
let e = t[s..].find('"')? + s;
Some(t[s..e].to_string())
} else {
None
}
})
.collect()
}
/// Minify each script individually, then concatenate (safer than a monolith parse).
fn build_js_bundle(static_dir: &Path, script_paths: &[String]) -> String {
let mut bundle = String::with_capacity(512 * 1024);
for path in script_paths {
let file = static_dir.join(path.trim_start_matches('/'));
if file.exists() {
let src = fs::read_to_string(&file).unwrap_or_default();
let min = js_minify_safe(&src);
bundle.push_str(&min);
bundle.push_str(";\n");
} else {
eprintln!("cargo:warning=JS not found: {}", file.display());
}
}
bundle
}
/// Minify JS via oxc — returns original on failure.
fn js_minify_safe(source: &str) -> String {
if source.trim().is_empty() {
return String::new();
}
js_minify(source).unwrap_or_else(|e| {
eprintln!("cargo:warning=JS minify failed: {e}");
source.to_string()
})
}
fn js_minify(source: &str) -> Result<String, String> {
use oxc_allocator::Allocator;
use oxc_codegen::{Codegen, CodegenOptions, CommentOptions};
use oxc_minifier::{CompressOptions, CompressOptionsUnused, Minifier, MinifierOptions};
use oxc_parser::Parser;
use oxc_span::SourceType;
let allocator = Allocator::default();
let source_type = SourceType::cjs(); // Non-module, script mode
let ret = Parser::new(&allocator, source, source_type).parse();
if !ret.errors.is_empty() {
let msgs: Vec<_> = ret.errors.iter().take(3).map(|e| format!("{e}")).collect();
return Err(format!("parse errors: {}", msgs.join("; ")));
}
let mut program = ret.program;
// Compress (constant-fold, dead-code) — NO mangle (globals would break)
// Keep unused top-level functions: they're called cross-file via window.*
Minifier::new(MinifierOptions {
mangle: None,
compress: Some(CompressOptions {
unused: CompressOptionsUnused::Keep,
..CompressOptions::default()
}),
})
.minify(&allocator, &mut program);
let output = Codegen::new()
.with_options(CodegenOptions {
minify: true,
comments: CommentOptions {
normal: false,
jsdoc: false,
..CommentOptions::default()
},
..Default::default()
})
.build(&program);
Ok(output.code)
}
/// Walk a directory and minify every `.js` in-place (skips generated bundles).
fn minify_tree_js(dir: &Path, skip_prefix: &str) {
let Ok(entries) = fs::read_dir(dir) else { return };
for entry in entries.flatten() {
let p = entry.path();
if p.is_dir() {
minify_tree_js(&p, skip_prefix);
} else if p.extension().is_some_and(|e| e == "js") {
let fname = p.file_name().unwrap().to_string_lossy();
if fname.starts_with("app.") {
continue;
}
if let Ok(src) = fs::read_to_string(&p) {
let _ = fs::write(&p, js_minify_safe(&src));
}
}
}
}
// ═══════════════════════════════════════════════════════════════════════════════
// JSON minification (no external deps)
// ═══════════════════════════════════════════════════════════════════════════════
fn minify_tree_json(dir: &Path) {
let Ok(entries) = fs::read_dir(dir) else { return };
for entry in entries.flatten() {
let p = entry.path();
if p.extension().is_some_and(|e| e == "json") {
if let Ok(src) = fs::read_to_string(&p) {
let _ = fs::write(&p, json_minify(&src));
}
}
}
}
/// Strip insignificant whitespace outside JSON strings.
fn json_minify(source: &str) -> String {
let mut out = String::with_capacity(source.len());
let mut in_string = false;
let mut escape = false;
for ch in source.chars() {
if escape {
out.push(ch);
escape = false;
continue;
}
if in_string {
out.push(ch);
if ch == '\\' {
escape = true;
} else if ch == '"' {
in_string = false;
}
} else {
match ch {
'"' => {
in_string = true;
out.push(ch);
}
' ' | '\n' | '\r' | '\t' => {} // drop whitespace
_ => out.push(ch),
}
}
}
out
}
// ═══════════════════════════════════════════════════════════════════════════════
// HTML rewriting
// ═══════════════════════════════════════════════════════════════════════════════
/// Rewrite index.html: single CSS bundle, inline theme-init, single JS bundle.
fn rewrite_index_html(
html: &str,
css_path: &str,
js_path: &str,
inline_theme_js: &str,
) -> String {
let mut out: Vec<String> = Vec::with_capacity(html.lines().count());
let mut css_done = false;
let mut defer_done = false;
for line in html.lines() {
let t = line.trim();
// ── Replace all stylesheet <link>s with single bundle ────────────────
if t.starts_with("<link") && t.contains("stylesheet") && t.contains("href=\"/css/") {
if !css_done {
out.push(format!(
" <link rel=\"stylesheet\" href=\"{css_path}\">"
));
css_done = true;
}
continue;
}
// ── Replace sync theme-init.js with inline <script> ─────────────────
if t.starts_with("<script")
&& !t.contains("defer")
&& t.contains("theme-init")
{
out.push(format!(" <script>{inline_theme_js}</script>"));
continue;
}
// ── Replace all defer <script>s with single bundle ──────────────────
if t.starts_with("<script") && t.contains("defer") && t.contains("src=\"") {
if !defer_done {
out.push(format!(
" <script defer src=\"{js_path}\"></script>"
));
defer_done = true;
}
continue;
}
// ── Drop "Service Worker Registration" comment ──────────────────────
if t.contains("Service Worker Registration") {
continue;
}
// ── Drop "Styles" / "Scripts" section comments ──────────────────────
if t.starts_with("<!--") && (t.contains("Styles") || t.contains("Scripts (defer")) {
continue;
}
out.push(line.to_string());
}
out.join("\n")
}
// ═══════════════════════════════════════════════════════════════════════════════
// Service Worker cache-list update
// ═══════════════════════════════════════════════════════════════════════════════
fn update_sw_cache(sw: &str, css_bundle: &str, js_bundle: &str) -> String {
let marker_start = "const ASSETS_TO_CACHE = [";
let marker_end = "];";
let Some(start) = sw.find(marker_start) else {
return sw.to_string();
};
let Some(end_off) = sw[start..].find(marker_end) else {
return sw.to_string();
};
let before = &sw[..start];
let after = &sw[start + end_off + marker_end.len()..];
format!(
"{before}const ASSETS_TO_CACHE = [\n\
\x20 '/',\n\
\x20 '/index.html',\n\
\x20 '/css/{css_bundle}',\n\
\x20 '/js/{js_bundle}',\n\
\x20 '/locales/en.json',\n\
\x20 '/locales/es.json',\n\
\x20 '/favicon.ico'\n\
]{after}"
)
}
// ═══════════════════════════════════════════════════════════════════════════════
// Utilities
// ═══════════════════════════════════════════════════════════════════════════════
fn penv(key: &str) -> PathBuf {
PathBuf::from(std::env::var(key).unwrap_or_else(|_| panic!("{key} not set")))
}
fn env_or(key: &str, default: &str) -> String {
std::env::var(key).unwrap_or_else(|_| default.to_string())
}
/// FNV-1a hash → 8 hex chars. Fast, non-crypto, perfect for cache-busting.
fn fnv_hash(data: &[u8]) -> String {
let mut h: u64 = 0xcbf29ce484222325;
for &b in data {
h ^= b as u64;
h = h.wrapping_mul(0x100000001b3);
}
format!("{h:016x}")
}
/// Recursively copy a directory tree.
fn copy_dir_recursive(src: &Path, dst: &Path) -> io::Result<()> {
fs::create_dir_all(dst)?;
for entry in fs::read_dir(src)? {
let entry = entry?;
let src_path = entry.path();
let dst_path = dst.join(entry.file_name());
if entry.file_type()?.is_dir() {
copy_dir_recursive(&src_path, &dst_path)?;
} else {
fs::copy(&src_path, &dst_path)?;
}
}
Ok(())
}
-1
View File
@@ -36,7 +36,6 @@ services:
- .env
volumes:
- storage_data:/app/storage
- ./static:/app/static
networks:
oxicloud:
+4 -1
View File
@@ -135,7 +135,10 @@ pub async fn handle_login_page(
return StatusCode::NOT_FOUND.into_response();
}
html_with_csp(include_str!("../../../static/nextcloud-login.html"))
html_with_csp(include_str!(concat!(
env!("OUT_DIR"),
"/nextcloud-login.html"
)))
}
pub async fn handle_login_submit(
+21 -6
View File
@@ -11,13 +11,25 @@ use tower_http::set_header::SetResponseHeaderLayer;
pub fn create_web_routes() -> Router<Arc<AppState>> {
// Get config to access static path
let config = AppConfig::from_env();
let static_path = config.static_path.clone();
// In release builds, serve from static-dist/ (processed assets).
// In debug builds, serve from the original static/ directory.
let static_path = if cfg!(not(debug_assertions)) {
let dist = config
.static_path
.parent()
.unwrap_or(std::path::Path::new("."))
.join("static-dist");
if dist.exists() { dist } else { config.static_path.clone() }
} else {
config.static_path.clone()
};
// Static assets (JS, CSS, JSON, SVG, ICO) served via ServeDir
// with brotli + gzip compression and aggressive caching (7 days).
// HTML pages are served via explicit routes (include_str!) and
// do NOT pass through these layers.
let static_service = ServeDir::new(static_path);
let static_service = ServeDir::new(&static_path);
Router::new()
// Add specific routes for clean URLs (without .html)
@@ -36,20 +48,23 @@ pub fn create_web_routes() -> Router<Arc<AppState>> {
/// Serve the login page
async fn serve_login_page() -> Html<&'static str> {
Html(include_str!("../../../static/login.html"))
Html(include_str!(concat!(env!("OUT_DIR"), "/login.html")))
}
/// Serve the profile page
async fn serve_profile_page() -> Html<&'static str> {
Html(include_str!("../../../static/profile.html"))
Html(include_str!(concat!(env!("OUT_DIR"), "/profile.html")))
}
/// Serve the admin page
async fn serve_admin_page() -> Html<&'static str> {
Html(include_str!("../../../static/admin.html"))
Html(include_str!(concat!(env!("OUT_DIR"), "/admin.html")))
}
/// Serve the device verification page (RFC 8628 Device Authorization Grant)
async fn serve_device_verify_page() -> Html<&'static str> {
Html(include_str!("../../../static/device-verify.html"))
Html(include_str!(concat!(
env!("OUT_DIR"),
"/device-verify.html"
)))
}