cjw/Oxicloud
1
0
Fork 0
Code Issues Pull Requests Actions 4 Packages Projects Releases Wiki Activity

fix: resolve file management operations not working (#83)

Browse Source 
- Fix rename: context menu was nullifying target reference before rename dialog could use it
- Fix delete files/folders: auth extractors were mandatory, causing 401 when auth not configured
- Fix view-file: async fetch race condition with context menu cleanup
- Fix orphaned ID mappings on file deletion
- Fix Authorization: Bearer null headers sent without token
- Add OptionalUserId and OptionalAuthUser infallible extractors
This commit is contained in:
Dionisio
2026-02-13 08:54:51 +01:00
parent 915d9a4353
commit fb65d1976b
9 changed files with 294 additions and 63 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/interfaces/api/handlers/trash_handler.rs
+13 -10
View File
@@ -6,7 +6,7 @@ use tracing::{debug, error, warn, instrument};
// use crate::application::ports::trash_ports::TrashUseCase;
use crate::common::di::AppState;
use crate::interfaces::middleware::auth::AuthUser;
use crate::interfaces::middleware::auth::{AuthUser, OptionalAuthUser};
/// Gets all items in the trash for the current user
#[instrument(skip_all)]
@@ -50,11 +50,12 @@ pub async fn get_trash_items(
#[instrument(skip_all)]
pub async fn move_to_trash(
State(state): State<AppState>,
auth_user: AuthUser,
OptionalAuthUser(auth_user): OptionalAuthUser,
Path((item_type, item_id)): Path<(String, String)>,
) -> (StatusCode, Json<serde_json::Value>) {
let user_id = auth_user.as_ref().map(|u| u.id.as_str()).unwrap_or("anonymous");
debug!("Request to move to trash: type={}, id={}, user={}",
item_type, item_id, auth_user.id);
item_type, item_id, user_id);
let trash_service = match state.trash_service.as_ref() {
Some(service) => service,
@@ -64,7 +65,7 @@ pub async fn move_to_trash(
})));
}
};
let result = trash_service.move_to_trash(&item_id, &item_type, &auth_user.id).await;
let result = trash_service.move_to_trash(&item_id, &item_type, user_id).await;
match result {
Ok(_) => {
@@ -87,11 +88,12 @@ pub async fn move_to_trash(
#[instrument(skip_all)]
pub async fn move_file_to_trash(
State(state): State<AppState>,
auth_user: AuthUser,
OptionalAuthUser(auth_user): OptionalAuthUser,
Path(item_id): Path<String>,
) -> (StatusCode, Json<serde_json::Value>) {
let user_id = auth_user.as_ref().map(|u| u.id.as_str()).unwrap_or("anonymous");
debug!("Request to move file to trash: id={}, user={}",
item_id, auth_user.id);
item_id, user_id);
let trash_service = match state.trash_service.as_ref() {
Some(service) => service,
@@ -103,7 +105,7 @@ pub async fn move_file_to_trash(
};
// Specify that it is a file
let result = trash_service.move_to_trash(&item_id, "file", &auth_user.id).await;
let result = trash_service.move_to_trash(&item_id, "file", user_id).await;
match result {
Ok(_) => {
@@ -126,11 +128,12 @@ pub async fn move_file_to_trash(
#[instrument(skip_all)]
pub async fn move_folder_to_trash(
State(state): State<AppState>,
auth_user: AuthUser,
OptionalAuthUser(auth_user): OptionalAuthUser,
Path(item_id): Path<String>,
) -> (StatusCode, Json<serde_json::Value>) {
let user_id = auth_user.as_ref().map(|u| u.id.as_str()).unwrap_or("anonymous");
debug!("Request to move folder to trash: id={}, user={}",
item_id, auth_user.id);
item_id, user_id);
let trash_service = match state.trash_service.as_ref() {
Some(service) => service,
@@ -142,7 +145,7 @@ pub async fn move_folder_to_trash(
};
// Specify that it is a folder
let result = trash_service.move_to_trash(&item_id, "folder", &auth_user.id).await;
let result = trash_service.move_to_trash(&item_id, "folder", user_id).await;
match result {
Ok(_) => {