Claude
aba89c4f5d
Every change is benchmark-verified (harness + before/after numbers in benches/, measured on this branch; reproduction commands in each doc): DAV / sync-client hot paths - PROPFIND dead-properties: one = ANY($1) query per 500-child page instead of one sequential query per child, and indexable `=` predicates instead of IS NOT DISTINCT FROM (seq scans). 2,000-child folder: 1.07-4.54 s of DB chatter -> 4-6 ms (258-773x). Applied to native + NC PROPFIND and both NC REPORT handlers. [benches/DEAD-PROPS.md] - Folder paging: keyset cursor (name > $last) + new partial index (folder_id, name) replaces LIMIT/OFFSET full-folder rescan per page. Full 20k-file walk: 1266 ms -> 77 ms (16.5x). New migration 20260917000000. [benches/PROPFIND-PAGING.md] - NC chroot / default-drive resolution: moka caches (30 s TTL, explicit invalidation on drive mutations) for find_default_for_user and the markerless chroot FolderDto. 2 uncached queries + 2 pool checkouts per NC/WebDAV/WOPI request -> sub-us moka hit (p50 0.7-3.6 ms -> ~1 us). [benches/CHROOT-CACHE.md] - Quota: PROPFINDs whose prop list never names a quota prop skip the 2-query resolution entirely (wants_quota()); the remaining lookups read 2 columns instead of the full auth.users row with its <=512 KiB avatar (11-16x, p50 3.4 ms -> 0.29 ms). Same narrow read now gates every upload quota check. [benches/QUOTA-PATH.md] CPU on the request path - ZIP exports (folder download, share ZIP, batch download): entries whose MIME says already-compressed (JPEG/MP4/zip/pdf/...) are Stored instead of Deflate - deflate ran inline on the tokio writer task at ~41 MB/s for ~0% size gain. Mixed media corpus: 4.31x wall and CPU, archive size unchanged. Shared predicate in common::mime_detect. [benches/ZIP-MEDIA.md] - Compression layers: tower-http's default maps to Brotli QUALITY 11 (verified in brotli-8.0.2 source and empirically: 90 ms per 64 KiB JSON response, 1.3 s per 700 KiB bundle). Both layers pinned to Precise(4): 99x less CPU for ~15% more bytes. SPA assets are now precompressed at build time (scripts/precompress.mjs, 77% smaller) and served via ServeDir::precompressed_br/gzip: 2016x less per-request work, and clients get the better q11 bytes. [benches/STATIC-PRECOMPRESSED.md] Batched / cached backend paths [benches/NPLUS1-AND-CACHES.md] - Content-search ReBAC re-verification: new AuthorizationEngine::check_files_read_batch (default = old loop; PgAclEngine override batches drive resolution + reuses role cache). 200 sequential point SELECTs per search -> 1-2 queries. - Batch-ZIP subtree downloads: drop per-file re-authz + per-file Recent recording (2 writes/file) for subtree entries already authorized at the root - mirrors the native folder-download path. ~6,000 statements removed from a 2,000-file archive. - CDC chunk manifests: immutable by content address, now moka-cached (weight-bounded 32 MiB, 60 s TTL, positive-only, invalidated on delete) - removes one manifest query (p50 0.44-4.4 ms) from every stream, range and full blob read. - People tab: grouped COUNT + batched cover lookup instead of dragging every face row with its 2 KiB embedding (10k faces: 30.4 ms & 21 MB -> 3.8 ms & 1.3 KB, 8.1x); merge() is one set-based UPDATE. [benches/PEOPLE-LIST.md] - Photos timeline cursor: raw timestamptz comparison instead of EXTRACT(EPOCH ...) wrapper + IS NULL OR disjunction - cursor is an index boundary again, deep scroll stops re-scanning skipped rows. - Public share landing: one atomic UPDATE ... access_count + 1 (was SELECT + full-row write-back: racy, lost updates, clobbered concurrent owner edits) - 3 round-trips -> 2 per visit. - move_to_trash: dead full-entity SELECT feeding a documented no-op removed from both branches; dead fields dropped from TrashService. - NFC normalization: is_nfc_quick fast path skips the decompose/recompose state machine for the ~100% already-NFC case (every row loaded from PG). Frontend - Large folders paint after page one (~200 items) via fetchFolderListing's new onPage hook instead of waiting for every sequential page. - Tested-and-reverted (kept for the record): cached Intl.Collator for name sorts - vitest showed it 2x SLOWER than V8's argument-less localeCompare fast path (5.6 ms vs 12.1 ms / 5k names). Sort order untouched. New bench harnesses under examples/ (bench feature): zip_media, dead_props, chroot_cache, quota_path, people_list, propfind_paging, static_precompress. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CBK1RdtzyP6759Muqe1K1w
43 lines
2.1 KiB
Markdown
43 lines
2.1 KiB
Markdown
# Quota path — narrow 2-column read + skip-when-not-requested
|
||
|
||
Two independent fixes on the quota resolution that runs on every upload check
|
||
and every quota-reporting folder PROPFIND:
|
||
|
||
1. **Narrow read.** `check_storage_quota` / `get_user_storage_info` called
|
||
`get_user_by_id`, whose SELECT drags the entire `auth.users` row —
|
||
including `image`, an avatar data URI of up to 512 KiB — to read two i64s.
|
||
New `UserPgRepository::get_storage_usage` reads exactly
|
||
`(storage_used_bytes, storage_quota_bytes)` (same pattern as the existing
|
||
`get_user_flags`).
|
||
2. **Skip entirely when not asked.** `resolve_webdav_quota` (2 round-trips:
|
||
drive row + user row) ran on EVERY folder PROPFIND on both surfaces, even
|
||
when the client's `<D:prop>` list named no quota property — which is the
|
||
common shape for sync-client polls. `PropFindRequest::wants_quota()` now
|
||
gates it: `AllProp`/`PropName` keep quota (the writers emit RFC 4331 props
|
||
there), explicit prop lists trigger the lookups only if they name
|
||
`quota-used-bytes` / `quota-available-bytes`. Responses are byte-identical
|
||
for every request that names quota or asks for allprop.
|
||
|
||
## Reproduce
|
||
|
||
```bash
|
||
cargo run --release --features bench --example bench_quota_path
|
||
# tunables: BENCH_SECONDS=4 BENCH_CONCURRENCIES=8,64 BENCH_IMAGE_KB=512
|
||
```
|
||
|
||
## Results (4 cores, local PG16, pool=20, 512 KiB avatar on the row)
|
||
|
||
| conc | mode | ops/s | p50 µs | p99 µs |
|
||
|-----:|--------|-------:|---------:|---------:|
|
||
| 8 | FULL | 2,222 | 3,369.4 | 8,452.2 |
|
||
| 8 | NARROW | 25,118 | 294.9 | 867.9 |
|
||
| 64 | FULL | 2,567 | 24,642.3 | 36,164.0 |
|
||
| 64 | NARROW | 40,195 | 1,468.9 | 3,964.9 |
|
||
|
||
- **11–16× throughput, p50 3.4 ms → 0.29 ms** for the user-row half of every
|
||
quota resolution (the avatar bytes dominated the wire+decode cost).
|
||
- With `wants_quota()` the common PROPFIND pays **zero** quota queries — the
|
||
numbers above then only apply to requests that actually ask for quota.
|
||
- The same narrow read protects every upload (`check_storage_quota` gates all
|
||
upload paths), where the FULL row was pure overhead per file.
|