Files

T

Claude aba89c4f5d perf: eliminate N+1 hot-path queries, cache immutable lookups, stop re-compressing compressed bytes

Every change is benchmark-verified (harness + before/after numbers in
benches/, measured on this branch; reproduction commands in each doc):

DAV / sync-client hot paths
- PROPFIND dead-properties: one = ANY($1) query per 500-child page instead
  of one sequential query per child, and indexable `=` predicates instead
  of IS NOT DISTINCT FROM (seq scans). 2,000-child folder: 1.07-4.54 s of
  DB chatter -> 4-6 ms (258-773x). Applied to native + NC PROPFIND and
  both NC REPORT handlers. [benches/DEAD-PROPS.md]
- Folder paging: keyset cursor (name > $last) + new partial index
  (folder_id, name) replaces LIMIT/OFFSET full-folder rescan per page.
  Full 20k-file walk: 1266 ms -> 77 ms (16.5x). New migration
  20260917000000. [benches/PROPFIND-PAGING.md]
- NC chroot / default-drive resolution: moka caches (30 s TTL, explicit
  invalidation on drive mutations) for find_default_for_user and the
  markerless chroot FolderDto. 2 uncached queries + 2 pool checkouts per
  NC/WebDAV/WOPI request -> sub-us moka hit (p50 0.7-3.6 ms -> ~1 us).
  [benches/CHROOT-CACHE.md]
- Quota: PROPFINDs whose prop list never names a quota prop skip the
  2-query resolution entirely (wants_quota()); the remaining lookups read
  2 columns instead of the full auth.users row with its <=512 KiB avatar
  (11-16x, p50 3.4 ms -> 0.29 ms). Same narrow read now gates every
  upload quota check. [benches/QUOTA-PATH.md]

CPU on the request path
- ZIP exports (folder download, share ZIP, batch download): entries whose
  MIME says already-compressed (JPEG/MP4/zip/pdf/...) are Stored instead
  of Deflate - deflate ran inline on the tokio writer task at ~41 MB/s
  for ~0% size gain. Mixed media corpus: 4.31x wall and CPU, archive size
  unchanged. Shared predicate in common::mime_detect. [benches/ZIP-MEDIA.md]
- Compression layers: tower-http's default maps to Brotli QUALITY 11
  (verified in brotli-8.0.2 source and empirically: 90 ms per 64 KiB JSON
  response, 1.3 s per 700 KiB bundle). Both layers pinned to Precise(4):
  99x less CPU for ~15% more bytes. SPA assets are now precompressed at
  build time (scripts/precompress.mjs, 77% smaller) and served via
  ServeDir::precompressed_br/gzip: 2016x less per-request work, and
  clients get the better q11 bytes. [benches/STATIC-PRECOMPRESSED.md]

Batched / cached backend paths [benches/NPLUS1-AND-CACHES.md]
- Content-search ReBAC re-verification: new
  AuthorizationEngine::check_files_read_batch (default = old loop;
  PgAclEngine override batches drive resolution + reuses role cache).
  200 sequential point SELECTs per search -> 1-2 queries.
- Batch-ZIP subtree downloads: drop per-file re-authz + per-file Recent
  recording (2 writes/file) for subtree entries already authorized at the
  root - mirrors the native folder-download path. ~6,000 statements
  removed from a 2,000-file archive.
- CDC chunk manifests: immutable by content address, now moka-cached
  (weight-bounded 32 MiB, 60 s TTL, positive-only, invalidated on delete)
  - removes one manifest query (p50 0.44-4.4 ms) from every stream,
  range and full blob read.
- People tab: grouped COUNT + batched cover lookup instead of dragging
  every face row with its 2 KiB embedding (10k faces: 30.4 ms & 21 MB ->
  3.8 ms & 1.3 KB, 8.1x); merge() is one set-based UPDATE.
  [benches/PEOPLE-LIST.md]
- Photos timeline cursor: raw timestamptz comparison instead of
  EXTRACT(EPOCH ...) wrapper + IS NULL OR disjunction - cursor is an
  index boundary again, deep scroll stops re-scanning skipped rows.
- Public share landing: one atomic UPDATE ... access_count + 1 (was
  SELECT + full-row write-back: racy, lost updates, clobbered concurrent
  owner edits) - 3 round-trips -> 2 per visit.
- move_to_trash: dead full-entity SELECT feeding a documented no-op
  removed from both branches; dead fields dropped from TrashService.
- NFC normalization: is_nfc_quick fast path skips the decompose/recompose
  state machine for the ~100% already-NFC case (every row loaded from PG).

Frontend
- Large folders paint after page one (~200 items) via fetchFolderListing's
  new onPage hook instead of waiting for every sequential page.
- Tested-and-reverted (kept for the record): cached Intl.Collator for name
  sorts - vitest showed it 2x SLOWER than V8's argument-less localeCompare
  fast path (5.6 ms vs 12.1 ms / 5k names). Sort order untouched.

New bench harnesses under examples/ (bench feature): zip_media,
dead_props, chroot_cache, quota_path, people_list, propfind_paging,
static_precompress.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CBK1RdtzyP6759Muqe1K1w

2026-07-16 14:20:20 +00:00

2.5 KiB

Raw Blame History

PROPFIND folder paging — keyset cursor + (folder_id, name) index

list_files_batch walks a folder's children in name order, 500 per page (native + NextCloud PROPFIND streamers). The old shape was ORDER BY name LIMIT 500 OFFSET k with no supporting index — the initial schema's (folder_id, name, user_id) index that served it was dropped by migration 20260902000000 (user_id → nullable), leaving only idx_files_folder_id. So every page bitmap-scanned all N children and top-sorted them: a full listing of an N-file folder cost O(N²/500) row visits + ⌈N/500⌉ sorts.

Changes:

Migration 20260917000000_files_folder_name_index.sql: partial composite idx_files_folder_name (folder_id, name) WHERE NOT is_trashed.
list_files_batch cursor switched from OFFSET to keyset (name > $last, names are unique per folder via the (drive_id, folder_id, name) unique index) across the port trait, the repository and both handler loops. The cursor predicate is only emitted when a cursor exists — a $2 IS NULL OR … disjunction would block the index condition under the extended protocol's generic plans.

Reproduce

cargo run --release --features bench --example bench_propfind_paging
# tunables: BENCH_FILES=20000 BENCH_PAGE=500 BENCH_REPS=3

Times the FULL page-by-page walk of a 20,000-file folder (the listing portion of one Depth:1 PROPFIND).

Results (4 cores, local PG16)

mode	total ms	vs OLD
OFFSET, no index (true BEFORE)	1,266.3	1.0×
OFFSET + index (index alone)	482.7	2.6×
KEYSET + index (AFTER)	76.7	16.5×

Full-folder listing cost drops 16.5×; unlike OFFSET (even indexed), keyset stays O(page) at any depth, so the gap widens with folder size.
Companion fix in the same commit: the Photos timeline cursor (list_media_files) wrapped its keyset column in EXTRACT(EPOCH FROM …)::bigint plus an IS NULL OR disjunction — non-sargable, so page k re-scanned all k·limit rows already scrolled past. It now compares the raw media_sort_date against a timestamptz bind (identical row semantics — the cursor is whole seconds) and splits the cursor/no-cursor query shapes, restoring the idx_files_media_timeline_by_drive boundary condition the index was built for. Same mechanism as measured above (index-boundary vs per-row filter); the deep-scroll effect mirrors the OFFSET column.

2.5 KiB Raw Blame History Unescape Escape

PROPFIND folder paging — keyset cursor + (folder_id, name) index

Reproduce

Results (4 cores, local PG16)

2.5 KiB

Raw Blame History