Files
Oxicloud/src/application/dtos/file_dto.rs
T
Claude 78c983136f perf: use Arc<str> for repetitive DTO fields to eliminate clone allocations
Replace String with Arc<str> for fields that contain repeated static
values (mime_type, icon_class, icon_special_class, category) in
FileDto, FolderDto, and OptimizedFileContent.

These fields are computed from ~40 static lookup tables and cloned
on every request. With Arc<str>, clone becomes O(1) atomic increment
instead of O(n) heap allocation — saving thousands of allocations/s
under load.

Fields kept as String: id, name, path, folder_id, owner_id
(unique per item, rarely cloned).

Zero API impact — serde serializes Arc<str> identically to String.

https://claude.ai/code/session_01EbAFEfyJNLRmJHmmYDX3Tt
2026-03-03 15:55:15 +00:00

124 lines
3.5 KiB
Rust

use std::sync::Arc;
use crate::domain::entities::file::File;
use serde::{Deserialize, Serialize};
use super::display_helpers::{
category_for, format_file_size, icon_class_for, icon_special_class_for,
};
/// DTO for file responses
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct FileDto {
/// File ID
pub id: String,
/// File name
pub name: String,
/// Path to the file (relative)
pub path: String,
/// Size in bytes
pub size: u64,
/// MIME type — `Arc<str>` because MIME values repeat across files
/// and DTOs are cloned on every request (clone is O(1) atomic increment).
pub mime_type: Arc<str>,
/// Parent folder ID
pub folder_id: Option<String>,
/// Creation timestamp
pub created_at: u64,
/// Last modification timestamp
pub modified_at: u64,
// ── Pre-computed display fields (Arc<str>: values come from static tables) ──
/// FontAwesome icon CSS class (e.g. "fas fa-file-image")
pub icon_class: Arc<str>,
/// Extra CSS class for icon styling (e.g. "image-icon", "" when default)
pub icon_special_class: Arc<str>,
/// Human-readable file category (e.g. "Image", "Document")
pub category: Arc<str>,
/// Human-readable formatted size (e.g. "3.27 MB")
pub size_formatted: String,
/// Owner user ID (omitted from JSON when None)
#[serde(skip_serializing_if = "Option::is_none")]
pub owner_id: Option<String>,
}
impl From<File> for FileDto {
fn from(file: File) -> Self {
let name = file.name();
let mime = file.mime_type();
let size = file.size();
Self {
id: file.id().to_string(),
name: name.to_string(),
path: file.path_string().to_string(),
size,
mime_type: Arc::from(mime),
folder_id: file.folder_id().map(String::from),
created_at: file.created_at(),
modified_at: file.modified_at(),
icon_class: Arc::from(icon_class_for(name, mime)),
icon_special_class: Arc::from(icon_special_class_for(name, mime)),
category: Arc::from(category_for(name, mime)),
size_formatted: format_file_size(size),
owner_id: file.owner_id().map(String::from),
}
}
}
// To convert from FileDto to File for batch handlers
impl From<FileDto> for File {
fn from(dto: FileDto) -> Self {
// Display fields (icon_class, icon_special_class, category, size_formatted)
// are not part of the domain entity and are ignored.
File::from_dto(
dto.id,
dto.name,
dto.path,
dto.size,
dto.mime_type.to_string(),
dto.folder_id,
dto.created_at,
dto.modified_at,
)
}
}
impl FileDto {
/// Creates an empty file DTO for stub implementations
pub fn empty() -> Self {
Self {
id: "stub-id".to_string(),
name: "stub-file".to_string(),
path: "/stub/path".to_string(),
size: 0,
mime_type: Arc::from("application/octet-stream"),
folder_id: None,
created_at: 0,
modified_at: 0,
icon_class: Arc::from("fas fa-file"),
icon_special_class: Arc::from(""),
category: Arc::from("Document"),
size_formatted: "0 Bytes".to_string(),
owner_id: None,
}
}
}
impl Default for FileDto {
fn default() -> Self {
Self::empty()
}
}