8794324c3d
Extends windowing to the remaining O(n)-DOM surfaces: the card-grid view of ResourceList (recent / favorites / shared / shared-with-me / trash / search) and the main file browser (`files/[...path]`), in both list and grid layouts. - VirtualList gains a real grid mode: its inner window carries the caller's grid class (`files-grid-view`) and lays out `columns` cards per windowed row. The row pitch is auto-measured (grid card height tracks column width via the 4/3 aspect-ratio thumbnail) and re-measured on resize. - `useVirtualWindow` now distinguishes scroll from resize and exposes a `resizeTick`, so size-dependent layout (the grid pitch) is recomputed only when it can actually change. - `gridColumns(width)` (new util) mirrors the CSS `auto-fill` / `--grid-card-min` / gap so the windowed row count matches the browser's real wrapping exactly; shared by both grid callers. - The files browser flattens folders-then-files into one discriminated `entries` list rendered through VirtualList (list: columns=1; grid: columns from width). Grouped (swimlane) views stay fully rendered, as before — they're bounded. ResourceList GRID, headless Chromium (1280x900), synthetic rows, before/after: rows | mount→paint | DOM nodes | JS heap | scroll frame | jank frames ------+-------------+-----------+---------+--------------+------------ 1000 | 979→75 ms | 19k→879 | 16→3 MB | 16→17 ms | 0→0 5000 | 4005→67 ms | 95k→879 | 72→3 MB | 37→17 ms | 26→0 20000 |12015→65 ms | 380k→879 |281→7 MB |197→17 ms |1249→19 Rendered DOM and heap are flat (O(visible)) regardless of dataset size; mount is ~185x faster and scroll holds ~60fps. Verified visually mid-scroll (5 columns, 4/3 thumbnail tiles, cards land at the expected indices). The files browser shares the same VirtualList path (it can't be mounted headless — it depends on $app routing/session — so it's validated via svelte-check + the production build + the shared, separately-benchmarked component). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M8Vb9QHmLZnEMzHz7MrFy6
123 lines
4.1 KiB
Svelte
123 lines
4.1 KiB
Svelte
<script lang="ts" module>
|
|
/**
|
|
* Generic windowing list. Renders only the rows intersecting the nearest
|
|
* scrollable ancestor's viewport (plus an overscan margin), reserving the full
|
|
* scroll height with a sized spacer so the scrollbar, sticky headers and any
|
|
* end-of-list sentinel keep behaving exactly as with a fully-rendered list.
|
|
*
|
|
* Scroll-ancestor based (not its own scroll box) so it drops into the existing
|
|
* `.content-area` layout without changing the single-scrollbar UX. Row height
|
|
* is auto-measured for the single-column case; pass `rowHeight` as the estimate
|
|
* (and for multi-column grids, where it must be the row pitch incl. gap).
|
|
*/
|
|
export interface VirtualListProps<T> {
|
|
items: T[];
|
|
/** Row pitch in px (height incl. row gap). Auto-refined when columns === 1. */
|
|
rowHeight?: number;
|
|
/** Items per row; > 1 lays the window out as a grid. */
|
|
columns?: number;
|
|
/** Extra rows rendered above and below the viewport. */
|
|
overscan?: number;
|
|
/** Class applied to the inner window (e.g. the grid container class). */
|
|
windowClass?: string;
|
|
/** Inline style applied to the inner window (e.g. grid-template-columns). */
|
|
windowStyle?: string;
|
|
/** Stable key per item (defaults to the absolute index). */
|
|
key?: (item: T, index: number) => string | number;
|
|
row: import('svelte').Snippet<[T, number]>;
|
|
}
|
|
</script>
|
|
|
|
<script lang="ts" generics="T">
|
|
import { onMount } from 'svelte';
|
|
import { useVirtualWindow } from '$lib/composables/useVirtualWindow.svelte';
|
|
|
|
let {
|
|
items,
|
|
rowHeight = 48,
|
|
columns = 1,
|
|
overscan = 6,
|
|
windowClass = '',
|
|
windowStyle = '',
|
|
key,
|
|
row
|
|
}: VirtualListProps<T> = $props();
|
|
|
|
let rootEl: HTMLDivElement;
|
|
/** Measured row pitch in px; 0 until known, then refined from a real row. */
|
|
let measuredRow = $state(0);
|
|
const vw = useVirtualWindow();
|
|
|
|
const cols = $derived(Math.max(1, columns));
|
|
const effRowH = $derived(measuredRow > 0 ? measuredRow : rowHeight);
|
|
const rowCount = $derived(Math.ceil(items.length / cols));
|
|
const totalHeight = $derived(rowCount * effRowH);
|
|
|
|
// Visible row band, derived from the shared scroll signals + the row pitch.
|
|
const rh = $derived(effRowH || rowHeight);
|
|
const firstRow = $derived(Math.max(0, Math.floor(vw.aboveBy / rh) - overscan));
|
|
const lastRow = $derived(
|
|
Math.min(rowCount, Math.ceil((vw.aboveBy + vw.viewportH) / rh) + overscan)
|
|
);
|
|
const startIndex = $derived(firstRow * cols);
|
|
const endIndex = $derived(Math.min(items.length, lastRow * cols));
|
|
const offsetY = $derived(firstRow * effRowH);
|
|
const visible = $derived(items.slice(startIndex, endIndex));
|
|
|
|
/**
|
|
* Adopt the real rendered row pitch once rows exist. For a grid (cols > 1) the
|
|
* card height tracks the column width (e.g. an aspect-ratio thumbnail), so the
|
|
* pitch is the card height plus the grid's row gap, re-measured on resize.
|
|
*/
|
|
function refineRowHeight(): void {
|
|
const win = rootEl?.querySelector('.vlist__window') as HTMLElement | null;
|
|
const firstChild = win?.firstElementChild as HTMLElement | null;
|
|
if (!win || !firstChild) return;
|
|
let h = firstChild.getBoundingClientRect().height;
|
|
if (cols > 1) h += parseFloat(getComputedStyle(win).rowGap) || 0;
|
|
if (h > 0 && Math.abs(h - measuredRow) > 0.5) measuredRow = h;
|
|
}
|
|
|
|
onMount(() => {
|
|
const stop = vw.observe(rootEl);
|
|
requestAnimationFrame(() => {
|
|
refineRowHeight();
|
|
vw.remeasure();
|
|
});
|
|
return stop;
|
|
});
|
|
|
|
// Re-measure the row pitch when rows first render, columns change, or a resize
|
|
// reflows the cards (grid card height depends on the column width).
|
|
$effect(() => {
|
|
void visible.length;
|
|
void cols;
|
|
void vw.resizeTick;
|
|
refineRowHeight();
|
|
});
|
|
</script>
|
|
|
|
<div bind:this={rootEl} class="vlist" style:height="{totalHeight}px">
|
|
<div
|
|
class="vlist__window {windowClass}"
|
|
style="transform: translateY({offsetY}px); {windowStyle}"
|
|
>
|
|
{#each visible as item, i (key ? key(item, startIndex + i) : startIndex + i)}
|
|
{@render row(item, startIndex + i)}
|
|
{/each}
|
|
</div>
|
|
</div>
|
|
|
|
<style>
|
|
.vlist {
|
|
position: relative;
|
|
width: 100%;
|
|
}
|
|
|
|
.vlist__window {
|
|
position: absolute;
|
|
inset: 0 0 auto;
|
|
will-change: transform;
|
|
}
|
|
</style>
|