Claude
c51af68432
Benchmark-gated (benches/ROUND10.md; every change carries a BEFORE/AFTER harness with equivalence/safety gates — two designs were rejected or rewritten by their own benches before adoption): - Auth hot path: TokenClaims/CurrentUser display fields to Arc<str>, role to inline SmolStr end-to-end (Bearer, cookie, Basic-auth cache) — 4→1 allocs per authenticated request, 3→0 per warm DAV request; JWT Encoding/Decoding/Validation built once. - Cold shared-album herd: leader-inline parent batching in PgAclEngine (+ cascade try_get_with single-flight) — 100→2 parent queries per 100-thumb cold herd, herd wall 1.9x, sequential + warm paths unchanged, all ROUND8/9 safety gates plus new herd-equivalence gates. - Query-shape pack: share download double-fetch 2→1 (2.18x), contact-group COUNT(*) 14.9x, save_faces UNNEST 3.9x, playlist reorder UNNEST 63.7x (now atomic), search files∥folders join! 1.45x, move drive-lookup join! 2.14x, trash partial (drive_id, trashed_at) indexes, CalDAV event-gate narrow read, favorites/recents binary-decode port, dead count_files removed. - NC surface: preview + avatar honour If-None-Match (e2e: 5 KB and 197 KB → 0 bytes per revalidation), avatar WebP→PNG transcode memoised, PROPFIND/trashbin integer+date emits on stack formatters, folder-header enrichment join!, chunk-PUT retry stat folded into create_new open. - common::fmt integer rendering rewritten on the std 2-digit LUT after the round's own bench caught the div-loop losing to to_string (16.1 ns vs 22.5; speeds every prior-round call site). - Micro-pack: WebDAV scope probe borrow-only, ShareService base_url snapshot, cookie_secure OnceLock, Arc'd AES-GCM cipher, stack request-id, tantivy analyzer clone dropped. - SPA: search stale-guard + AbortController (10→1 completed round-trips, stale-clobber gone), getFolder in-flight dedup, gridColumns matchMedia hoist (10k→0 style reads). Backend: cargo fmt + clippy -D warnings clean, 524 tests green. Frontend: npm run check clean, 301 vitest green. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018DdM7V7M3QPW7HEHg3gLov
31 lines
1.9 KiB
SQL
31 lines
1.9 KiB
SQL
-- ════════════════════════════════════════════════════════════════════════════
|
|
-- Trash listing — partial (drive_id, trashed_at) indexes on trashed rows
|
|
-- ════════════════════════════════════════════════════════════════════════════
|
|
-- The trash surface (`TrashDbRepository::list_resources_paged`, `clear_trash`,
|
|
-- `get_all_trashed_file_ids`) filters `drive_id = ANY($drives) AND
|
|
-- is_trashed = TRUE` and keysets on `trashed_at` / `deletion_date`
|
|
-- (`deletion_date` = `trashed_at` + a constant retention interval, so it is
|
|
-- strictly monotonic in `trashed_at`).
|
|
--
|
|
-- The historical `idx_{files,folders}_trashed (user_id, is_trashed)` indexes
|
|
-- were dropped with the `user_id` columns (migration 20260904000000), leaving
|
|
-- only:
|
|
-- • `idx_{files,folders}_drive_id (drive_id)` — seeks the drive but then
|
|
-- filter-scans every LIVE row of the drive to find the trashed few;
|
|
-- • `idx_{files,folders}_trash_expiry (trashed_at) WHERE is_trashed` —
|
|
-- trashed-only but keyed for the GLOBAL retention sweeper; a per-drive
|
|
-- listing scans every tenant's trash and filters.
|
|
--
|
|
-- These partial indexes bound the read to exactly the caller's drives'
|
|
-- trashed rows, pre-ordered for the trashed_at/deletion_date keysets.
|
|
-- The retention sweeper keeps `idx_*_trash_expiry` (global, no drive
|
|
-- predicate). Benchmark: benches/ROUND10.md (trash-listing section).
|
|
|
|
CREATE INDEX IF NOT EXISTS idx_files_drive_trashed
|
|
ON storage.files (drive_id, trashed_at)
|
|
WHERE is_trashed;
|
|
|
|
CREATE INDEX IF NOT EXISTS idx_folders_drive_trashed
|
|
ON storage.folders (drive_id, trashed_at)
|
|
WHERE is_trashed;
|