DioCrafts
8981c1dfb9
An audit (backend /api routes vs SvelteKit frontend usage, adversarially
verified across the whole repo) found these 5 routes have ZERO callers — no
frontend, no test, no protocol layer, no internal caller — and are superseded:
- GET /api/folders/paginated no-op duplicate of GET /api/folders
(discards the page arg); superseded by
the cursor-paginated /{id}/resources.
- POST /api/dedup/upload superseded by /api/files/upload, which
does the identical CDC dedup ingest.
- POST /api/people/{id}/hide the hide-person toggle was never built
into the UI (is_hidden never read).
- GET /api/admin/settings/general never called anywhere.
- GET /api/admin/settings/registration only the PUT is used; the GET had no
caller (PUT kept).
Removes each route, its handler + _impl, the now-orphaned DedupUploadResponse
DTO + its two serialization tests, the set_hidden service method (only caller
was hide_person), and the OpenAPI path/schema registrations.
Also cleans 4 stale markers: two #[allow(deprecated)] that no longer suppress
anything (zero #[deprecated] remain), the "Legacy folder endpoints (contents,
listing)" comment (both already removed), and a "Re-export AppError for backward
compatibility" comment describing a re-export that doesn't exist.
Net -323 lines. The 31 other unused-by-frontend routes (device-code auth,
CardDAV contact-groups, people/photos & music WIP, dedup/admin debug, i18n,
openapi.json) are intentional surface and were left untouched.
cargo clippy --all-features --all-targets -D warnings: clean. cargo test: 446 passed.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
19 lines
807 B
Rust
19 lines
807 B
Rust
//! Application errors
|
|
//!
|
|
//! This module re-exports domain errors for compatibility.
|
|
//! Infrastructure error conversions (sqlx, serde_json, etc.)
|
|
//! are located in infrastructure/adapters/error_adapters.rs, following
|
|
//! Clean Architecture principles where the domain should not know about
|
|
//! infrastructure details.
|
|
|
|
// Re-export domain errors for compatibility
|
|
pub use crate::domain::errors::{DomainError, ErrorKind, Result};
|
|
|
|
// Infrastructure error conversions have been moved to:
|
|
// crate::infrastructure::adapters::error_adapters
|
|
//
|
|
// To convert infrastructure errors to DomainError, use:
|
|
// - The IntoDomainError trait for explicit conversions with context
|
|
// - Or handle errors in infrastructure repositories/services
|
|
// using map_err() with DomainError::internal_error() or similar methods
|