Bradley Nelson
e3823ce470
Add an end-to-end and unit test suite for the SvelteKit frontend:
- Playwright e2e specs (tests/e2e/spa) with a throwaway container stack,
codegen scenarios, and an Istanbul-based coverage report pipeline.
- Vitest unit tests across API endpoints, components, stores and composables.
- `data-testid` hooks on interactive elements (AppShell, FileViewer,
ShareDialog, search, photos, files breadcrumbs, login/Nextcloud flows,
public share pages) so the e2e suite can target them deterministically.
- Serve the SPA app-shell CSP from a <meta> policy (svelte.config.js) plus a
middleware that skips the CSP header on HTML; move the Nextcloud Login Flow
v2 grant page to the SvelteKit /nextcloud/login route.
- `just front-codegen` recipe and start-server-spa.sh harness.
Make the test environment robust and consistent:
- Install a deterministic in-memory localStorage/sessionStorage in the Vitest
setup so storage behaves identically across Node versions (Node 26 ships a
native Web Storage global that otherwise shadows jsdom's).
- Pin devenv to Node 26 + PostgreSQL 18 and pin every CI job to Node 26.3.0
so the dev shell and CI run the same toolchain versions.
Repair the API/WebDAV (hurl) suite, which had drifted from the backend:
- Migrate the removed `/api/folders/{id}/listing` endpoint to `/resources`
(cursor-paginated `{items:[{resource_type,resource}]}` shape) across the
batch-copy, grants, nested-group, and WebDAV NC tests + the dav_helpers
wipe routine.
- Stop photos_etag from uploading the dedup-tracked fixture so the dedup
blob-lifecycle test can own its content-addressed blob exclusively.
- dedup_create now asserts the idempotent same-content re-upload (201 +
existing file id) instead of the stale 409 expectation.
Generated coverage reports, nyc output and the e2e server runtime data dir
are gitignored rather than committed.
66 lines
2.8 KiB
TypeScript
66 lines
2.8 KiB
TypeScript
import { test, expect } from './coverage-helpers';
|
|
import { apiLogin, apiCreateFolder } from '../scenarios/helpers';
|
|
|
|
/**
|
|
* MoveDialog coverage — move a folder into another via the context menu.
|
|
* Exercises the move dialog's tree navigation and the folders move endpoint.
|
|
*/
|
|
test.beforeEach(async ({ page }) => {
|
|
await apiLogin(page);
|
|
});
|
|
|
|
function uniq(p: string): string {
|
|
return `${p}-${Date.now()}-${Math.floor(Math.random() * 1e6)}`;
|
|
}
|
|
|
|
test('move a folder into another via the move dialog', async ({ page }) => {
|
|
const srcName = uniq('MoveSrc');
|
|
const destName = uniq('MoveDest');
|
|
await apiCreateFolder(page, srcName);
|
|
const dest = await apiCreateFolder(page, destName);
|
|
|
|
await page.goto('/files');
|
|
await expect(page.getByTestId(srcName)).toBeVisible({ timeout: 15_000 });
|
|
|
|
await page.getByTestId(srcName).click({ button: 'right' });
|
|
await page.getByTestId('files-ctx-move-item').click();
|
|
await expect(page.getByTestId('move-dialog')).toBeVisible();
|
|
|
|
// Exercise the dialog tree navigation (into a folder, up to parent, home),
|
|
// then settle into the destination and confirm.
|
|
await page.getByTestId(`move-dialog-folder-${dest.id}`).click();
|
|
await page.getByTestId('move-dialog-parent-btn').click({ timeout: 3_000 }).catch(() => {});
|
|
await page.getByTestId('move-dialog-home-btn').click({ timeout: 3_000 }).catch(() => {});
|
|
await page.getByTestId(`move-dialog-folder-${dest.id}`).click();
|
|
await page.getByTestId('move-dialog-confirm-btn').click();
|
|
|
|
// Source left the root listing.
|
|
await expect(page.getByTestId(srcName)).toHaveCount(0, { timeout: 15_000 });
|
|
// And now lives inside the destination (route keys on folder id).
|
|
await page.goto(`/files/${dest.id}`);
|
|
await expect(page.getByTestId(srcName)).toBeVisible({ timeout: 15_000 });
|
|
});
|
|
|
|
test('navigate a nested tree in the move dialog', async ({ page }) => {
|
|
const srcName = uniq('NavSrc');
|
|
await apiCreateFolder(page, srcName);
|
|
const dest = await apiCreateFolder(page, uniq('NavDest'));
|
|
const sub = await apiCreateFolder(page, uniq('NavSub'), dest.id);
|
|
|
|
await page.goto('/files');
|
|
await expect(page.getByTestId(srcName)).toBeVisible({ timeout: 15_000 });
|
|
await page.getByTestId(srcName).click({ button: 'right' });
|
|
await page.getByTestId('files-ctx-move-item').click();
|
|
await expect(page.getByTestId('move-dialog')).toBeVisible();
|
|
|
|
// Descend dest → sub, climb back via parent, jump home, re-enter dest, move.
|
|
await page.getByTestId(`move-dialog-folder-${dest.id}`).click();
|
|
await page.getByTestId(`move-dialog-folder-${sub.id}`).click();
|
|
await page.getByTestId('move-dialog-parent-btn').click();
|
|
await page.getByTestId('move-dialog-home-btn').click();
|
|
await page.getByTestId(`move-dialog-folder-${dest.id}`).click();
|
|
await page.getByTestId('move-dialog-confirm-btn').click();
|
|
|
|
await expect(page.getByTestId(srcName)).toHaveCount(0, { timeout: 15_000 });
|
|
});
|