Bradley Nelson
e3823ce470
Add an end-to-end and unit test suite for the SvelteKit frontend:
- Playwright e2e specs (tests/e2e/spa) with a throwaway container stack,
codegen scenarios, and an Istanbul-based coverage report pipeline.
- Vitest unit tests across API endpoints, components, stores and composables.
- `data-testid` hooks on interactive elements (AppShell, FileViewer,
ShareDialog, search, photos, files breadcrumbs, login/Nextcloud flows,
public share pages) so the e2e suite can target them deterministically.
- Serve the SPA app-shell CSP from a <meta> policy (svelte.config.js) plus a
middleware that skips the CSP header on HTML; move the Nextcloud Login Flow
v2 grant page to the SvelteKit /nextcloud/login route.
- `just front-codegen` recipe and start-server-spa.sh harness.
Make the test environment robust and consistent:
- Install a deterministic in-memory localStorage/sessionStorage in the Vitest
setup so storage behaves identically across Node versions (Node 26 ships a
native Web Storage global that otherwise shadows jsdom's).
- Pin devenv to Node 26 + PostgreSQL 18 and pin every CI job to Node 26.3.0
so the dev shell and CI run the same toolchain versions.
Repair the API/WebDAV (hurl) suite, which had drifted from the backend:
- Migrate the removed `/api/folders/{id}/listing` endpoint to `/resources`
(cursor-paginated `{items:[{resource_type,resource}]}` shape) across the
batch-copy, grants, nested-group, and WebDAV NC tests + the dav_helpers
wipe routine.
- Stop photos_etag from uploading the dedup-tracked fixture so the dedup
blob-lifecycle test can own its content-addressed blob exclusively.
- dedup_create now asserts the idempotent same-content re-upload (201 +
existing file id) instead of the stale 409 expectation.
Generated coverage reports, nyc output and the e2e server runtime data dir
are gitignored rather than committed.
83 lines
3.3 KiB
TypeScript
83 lines
3.3 KiB
TypeScript
import { it, expect, vi, beforeEach } from 'vitest';
|
|
import { render, fireEvent, screen, waitFor } from '@testing-library/svelte';
|
|
|
|
vi.mock('$lib/api/endpoints/people', () => ({
|
|
fetchPeople: vi.fn(),
|
|
fetchPersonPhotos: vi.fn(),
|
|
renamePerson: vi.fn()
|
|
}));
|
|
vi.mock('$lib/api/endpoints/files', () => ({ fileThumbnailUrl: () => '/thumb.png' }));
|
|
vi.mock('$lib/stores/dialogs.svelte', () => ({ promptDialog: vi.fn() }));
|
|
|
|
import { fetchPeople, fetchPersonPhotos, renamePerson } from '$lib/api/endpoints/people';
|
|
import { promptDialog } from '$lib/stores/dialogs.svelte';
|
|
import PeopleView from './PeopleView.svelte';
|
|
|
|
const fp = fetchPeople as unknown as ReturnType<typeof vi.fn>;
|
|
const fpp = fetchPersonPhotos as unknown as ReturnType<typeof vi.fn>;
|
|
const rn = renamePerson as unknown as ReturnType<typeof vi.fn>;
|
|
const pd = promptDialog as unknown as ReturnType<typeof vi.fn>;
|
|
|
|
beforeEach(() => vi.clearAllMocks());
|
|
|
|
it('renders the people grid (named + unnamed)', async () => {
|
|
fp.mockResolvedValue([
|
|
{ id: 'p1', name: 'Alice', face_count: 3, cover_file_id: 'c1' },
|
|
{ id: 'p2', name: '', face_count: 1, cover_file_id: null }
|
|
]);
|
|
render(PeopleView);
|
|
expect(await screen.findByText('Alice')).toBeTruthy();
|
|
expect(screen.getByText('Unnamed')).toBeTruthy();
|
|
});
|
|
|
|
it('shows an empty state when there are no people', async () => {
|
|
fp.mockResolvedValue([]);
|
|
render(PeopleView);
|
|
expect(await screen.findByText('No people yet')).toBeTruthy();
|
|
});
|
|
|
|
it('shows the disabled state when the list errors', async () => {
|
|
fp.mockRejectedValue(new Error('off'));
|
|
render(PeopleView);
|
|
expect(await screen.findByText('Face recognition is disabled')).toBeTruthy();
|
|
});
|
|
|
|
it('drills into a person and back to the list', async () => {
|
|
fp.mockResolvedValue([{ id: 'p1', name: 'Alice', face_count: 2, cover_file_id: null }]);
|
|
fpp.mockResolvedValue(['ph1', 'ph2']);
|
|
render(PeopleView);
|
|
const btn = (await screen.findByText('Alice')).closest('button')!;
|
|
await fireEvent.click(btn);
|
|
await waitFor(() => expect(fpp).toHaveBeenCalledWith('p1'));
|
|
await fireEvent.click(screen.getByLabelText('Back'));
|
|
expect(await screen.findByText('Alice')).toBeTruthy();
|
|
});
|
|
|
|
it('renames the current person', async () => {
|
|
fp.mockResolvedValue([{ id: 'p1', name: 'Alice', face_count: 1, cover_file_id: null }]);
|
|
fpp.mockResolvedValue([]);
|
|
pd.mockResolvedValue('Bob');
|
|
rn.mockResolvedValue(undefined);
|
|
render(PeopleView);
|
|
await fireEvent.click((await screen.findByText('Alice')).closest('button')!);
|
|
await waitFor(() => screen.getByLabelText('Name this person'));
|
|
await fireEvent.click(screen.getByLabelText('Name this person'));
|
|
await waitFor(() => expect(rn).toHaveBeenCalledWith('p1', 'Bob'));
|
|
});
|
|
|
|
it("opens a person's photo in the lightbox", async () => {
|
|
fp.mockResolvedValue([{ id: 'p1', name: 'Alice', face_count: 2, cover_file_id: null }]);
|
|
fpp.mockResolvedValue(['ph1', 'ph2']);
|
|
const { container } = render(PeopleView);
|
|
await fireEvent.click((await screen.findByText('Alice')).closest('button')!);
|
|
await waitFor(() => expect(fpp).toHaveBeenCalledWith('p1'));
|
|
const tiles = await waitFor(() => {
|
|
const found = container.querySelectorAll('.photos__open');
|
|
if (found.length === 0) throw new Error('no tiles yet');
|
|
return found;
|
|
});
|
|
expect(tiles.length).toBe(2);
|
|
await fireEvent.click(tiles[0]);
|
|
expect(await screen.findByTestId('photo-lightbox')).toBeTruthy();
|
|
});
|